* [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131
[not found] <20220211205029.3940756-1-hugo@hugovil.com>
@ 2022-02-11 20:50 ` Hugo Villeneuve
2022-02-17 23:59 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Hugo Villeneuve @ 2022-02-11 20:50 UTC (permalink / raw)
To: hvilleneuve, a.zummo, alexandre.belloni, Rob Herring
Cc: hugo, linux-rtc, linux-kernel, devicetree
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Add support for new NXP RTC PCF2131.
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
.../devicetree/bindings/rtc/nxp,pcf2127.yaml | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
index cde7b1675ead..57eb0a58afa3 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
@@ -14,7 +14,9 @@ maintainers:
properties:
compatible:
- const: nxp,pcf2127
+ enum:
+ - nxp,pcf2127
+ - nxp,pcf2131
reg:
maxItems: 1
@@ -48,4 +50,19 @@ examples:
};
};
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rtc@53 {
+ compatible = "nxp,pcf2131";
+ reg = <0x53>;
+ pinctrl-0 = <&rtc_nint_pins>;
+ interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
+ reset-source;
+ };
+ };
+
...
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131
2022-02-11 20:50 ` [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131 Hugo Villeneuve
@ 2022-02-17 23:59 ` Rob Herring
2022-02-18 15:17 ` Hugo Villeneuve
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-02-17 23:59 UTC (permalink / raw)
To: Hugo Villeneuve
Cc: hvilleneuve, a.zummo, alexandre.belloni, linux-rtc, linux-kernel,
devicetree
On Fri, Feb 11, 2022 at 03:50:29PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Add support for new NXP RTC PCF2131.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..57eb0a58afa3 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,9 @@ maintainers:
>
> properties:
> compatible:
> - const: nxp,pcf2127
> + enum:
> + - nxp,pcf2127
> + - nxp,pcf2131
>
> reg:
> maxItems: 1
> @@ -48,4 +50,19 @@ examples:
> };
> };
>
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@53 {
> + compatible = "nxp,pcf2131";
> + reg = <0x53>;
> + pinctrl-0 = <&rtc_nint_pins>;
> + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> + reset-source;
> + };
> + };
Just a new compatible doesn't really justify another example.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131
2022-02-17 23:59 ` Rob Herring
@ 2022-02-18 15:17 ` Hugo Villeneuve
0 siblings, 0 replies; 3+ messages in thread
From: Hugo Villeneuve @ 2022-02-18 15:17 UTC (permalink / raw)
To: Rob Herring
Cc: hvilleneuve, a.zummo, alexandre.belloni, linux-rtc, linux-kernel,
devicetree
On Thu, 17 Feb 2022 17:59:21 -0600
Rob Herring <robh@kernel.org> wrote:
> On Fri, Feb 11, 2022 at 03:50:29PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > Add support for new NXP RTC PCF2131.
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> > .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 19 ++++++++++++++++++-
> > 1 file changed, 18 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > index cde7b1675ead..57eb0a58afa3 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -14,7 +14,9 @@ maintainers:
> >
> > properties:
> > compatible:
> > - const: nxp,pcf2127
> > + enum:
> > + - nxp,pcf2127
> > + - nxp,pcf2131
> >
> > reg:
> > maxItems: 1
> > @@ -48,4 +50,19 @@ examples:
> > };
> > };
> >
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + rtc@53 {
> > + compatible = "nxp,pcf2131";
> > + reg = <0x53>;
> > + pinctrl-0 = <&rtc_nint_pins>;
> > + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> > + reset-source;
> > + };
> > + };
>
> Just a new compatible doesn't really justify another example.
>
> Rob
Hi,
yes, now that I've remove the specific properties, the example can be removed.
Hugo.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-18 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220211205029.3940756-1-hugo@hugovil.com>
2022-02-11 20:50 ` [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131 Hugo Villeneuve
2022-02-17 23:59 ` Rob Herring
2022-02-18 15:17 ` Hugo Villeneuve
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).