Re: [PATCH v4 1/1] arm64: dts: qcom: msm8994-huawei-angler: Add sdhc1 definition

Petr Vorel
2022-03-23T20:40:39Z

Hi,

> Angler does not have SD card, thus sdhc2 kept disabled.

> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Hi all,

> credit for assigned-clock{s,-rates} goes to Konrad.
> Thanks!

> [ 1.567434] sdhci: Secure Digital Host Controller Interface driver
> [ 1.567477] sdhci: Copyright(c) Pierre Ossman
> [ 1.573265] Synopsys Designware Multimedia Card Interface Driver
> [ 1.577950] sdhci-pltfm: SDHCI platform and OF driver helper
> ...
> [ 1.631203] mmc0: SDHCI controller on f9824900.sdhci [f9824900.sdhci] using ADMA 64-bit
> ...
> ### postmarketOS initramfs ###
> ...
> [ 1.868905] mmc0: new HS400 MMC card at address 0001
> [ 1.871467] mmcblk0: mmc0:0001 064G70 58.2 GiB
> [ 1.876902] GPT:partition_entry_array_crc32 values don't match: 0x4aa75f3b != 0xe3345ddf
> [ 1.877211] GPT: Use GNU Parted to correct GPT errors.
> [ 1.886103] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15 p16 p17 p18 p19 p20 p21 p22 p23 p24 p25 p26 p27 p28 p29 p30 p31 p32 p33 p34 p35 p36 p37 p38 p39 p40 p41 p42 p43 p44
> [ 1.901299] mmcblk0boot0: mmc0:0001 064G70 4.00 MiB
> [ 1.908973] mmcblk0boot1: mmc0:0001 064G70 4.00 MiB
> [ 1.913706] mmcblk0rpmb: mmc0:0001 064G70 4.00 MiB, chardev (234:0)
> ERROR: failed to mount subpartitions!

> => no overclocking warnings.

> Kind regards,
> Petr

> .../boot/dts/qcom/msm8994-huawei-angler-rev-101.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)

> diff --git a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
> index 0e3dd48f0dbf..6dddf700f744 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /* Copyright (c) 2015, Huawei Inc. All rights reserved.
> * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> - * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com>
> + * Copyright (c) 2021-2022, Petr Vorel <petr.vorel@gmail.com>
> */

> /dts-v1/;
> @@ -41,3 +41,13 @@ serial@f991e000 {
> &tlmm {
> gpio-reserved-ranges = <85 4>;
> };
> +
> +&sdhc1 {
> + status = "okay";
> +
> + mmc-hs400-1_8v;
> +
> + /* avoid overclocking warnings */
> + assigned-clocks = <&gcc GPLL4_EARLY>;
> + assigned-clock-rates = <384000000>;
As I wrote at Konrad's patch "clk: qcom: gcc-msm8994: Fix gpll4 width" [1]
with that fix this workaround is not needed => I'll submit v5 without this.

Kind regards,
Petr

[1] https://lore.kernel.org/linux-arm-msm/YjuE+cgGXCLihPIa@pevik/T/#t
> +};