Re: [v3 11/13] iio: imu: add BNO055 serdev driver

kernel test robot
2022-02-18T05:21:21Z

Hi Andrea,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linux/master linus/master v5.17-rc4 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Andrea-Merello/Add-support-for-Bosch-BNO055-IMU/20220218-002932
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220218/202202181307.Lb4f99qg-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/98d7db4486f0404718da9e85ae13da54d757104b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andrea-Merello/Add-support-for-Bosch-BNO055-IMU/20220218-002932
git checkout 98d7db4486f0404718da9e85ae13da54d757104b
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/iio/imu/bno055/bno055.c:285:5: warning: no previous prototype for 'bno055_calibration_load' [-Wmissing-prototypes]
285 | int bno055_calibration_load(struct bno055_priv *priv, const u8 *data, int len)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/imu/bno055/bno055.c:748:5: warning: no previous prototype for 'bno055_sysfs_attr_avail' [-Wmissing-prototypes]
748 | int bno055_sysfs_attr_avail(struct bno055_priv *priv, struct bno055_sysfs_attr *attr,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/imu/bno055/bno055.c:1203:5: warning: no previous prototype for 'bno055_debugfs_reg_access' [-Wmissing-prototypes]
1203 | int bno055_debugfs_reg_access(struct iio_dev *iio_dev, unsigned int reg,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/imu/bno055/bno055.c: In function 'bno055_show_fw_version':
>> drivers/iio/imu/bno055/bno055.c:1235:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
1235 | kfree(buf);
| ^~~~~
| vfree
cc1: some warnings being treated as errors

vim +1235 drivers/iio/imu/bno055/bno055.c

16cbcd24402827b Andrea Merello 2022-02-17 1213
16cbcd24402827b Andrea Merello 2022-02-17 1214 static ssize_t bno055_show_fw_version(struct file *file, char __user *userbuf,
16cbcd24402827b Andrea Merello 2022-02-17 1215 size_t count, loff_t *ppos)
16cbcd24402827b Andrea Merello 2022-02-17 1216 {
16cbcd24402827b Andrea Merello 2022-02-17 1217 struct bno055_priv *priv = file->private_data;
16cbcd24402827b Andrea Merello 2022-02-17 1218 int rev, ver;
16cbcd24402827b Andrea Merello 2022-02-17 1219 char *buf;
16cbcd24402827b Andrea Merello 2022-02-17 1220 int ret;
16cbcd24402827b Andrea Merello 2022-02-17 1221
16cbcd24402827b Andrea Merello 2022-02-17 1222 ret = regmap_read(priv->regmap, BNO055_SW_REV_LSB_REG, &rev);
16cbcd24402827b Andrea Merello 2022-02-17 1223 if (ret)
16cbcd24402827b Andrea Merello 2022-02-17 1224 return ret;
16cbcd24402827b Andrea Merello 2022-02-17 1225
16cbcd24402827b Andrea Merello 2022-02-17 1226 ret = regmap_read(priv->regmap, BNO055_SW_REV_MSB_REG, &ver);
16cbcd24402827b Andrea Merello 2022-02-17 1227 if (ret)
16cbcd24402827b Andrea Merello 2022-02-17 1228 return ret;
16cbcd24402827b Andrea Merello 2022-02-17 1229
16cbcd24402827b Andrea Merello 2022-02-17 1230 buf = kasprintf(GFP_KERNEL, "ver: 0x%x, rev: 0x%x\n", ver, rev);
16cbcd24402827b Andrea Merello 2022-02-17 1231 if (!buf)
16cbcd24402827b Andrea Merello 2022-02-17 1232 return -ENOMEM;
16cbcd24402827b Andrea Merello 2022-02-17 1233
16cbcd24402827b Andrea Merello 2022-02-17 1234 ret = simple_read_from_buffer(userbuf, count, ppos, buf, strlen(buf));
16cbcd24402827b Andrea Merello 2022-02-17 @1235 kfree(buf);
16cbcd24402827b Andrea Merello 2022-02-17 1236
16cbcd24402827b Andrea Merello 2022-02-17 1237 return ret;
16cbcd24402827b Andrea Merello 2022-02-17 1238 }
16cbcd24402827b Andrea Merello 2022-02-17 1239

---
0-DAY CI Kernel Test Service, Intel Corporation