From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FE9C433FE for ; Mon, 21 Feb 2022 05:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344573AbiBUFfr (ORCPT ); Mon, 21 Feb 2022 00:35:47 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344560AbiBUFfo (ORCPT ); Mon, 21 Feb 2022 00:35:44 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41DE14AE22 for ; Sun, 20 Feb 2022 21:35:21 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id q11so2180354pln.11 for ; Sun, 20 Feb 2022 21:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=33J/57nAxSn7KHcYx9u5u+41MVedNA5dVhmvQ8pezfU=; b=oWfhdr7k2nhW6My+Jw699SkuwzOehDV+ERYV4S0wJGzSIA+D5A7otdDLVyUxXta/1s 6yQ55L+EMRIDv2aK2JEYK7DC3GUfyQK8GjcctyBWpM9OYMFxCTuAys7NjLTzGJ/P9NyC Bq7Z0kOuHa/Lo2tZz8ZYA6/LPwylRcTWQVOMxaQOp+l89MbpptCoVzB/LnNtkHoxnNgg JVe52SLiL32NkfgLgO/QIobIsHwKCqBFPp0AhuCkzK7SDfE04I8IkzFYaAm38UHezeAL F26pgCf7EvviSLZ3KuQx3T0/SO5faCXWMWk38eq8yQrgahovFTbbRksOPqUQ8csL1YkV JLfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=33J/57nAxSn7KHcYx9u5u+41MVedNA5dVhmvQ8pezfU=; b=qV7QPm60BhB4e0d93Srw0RlybNhZmmA7z6PXFebrYVaiZmPQgaT2HEOeNnZNXJ0k8Q uDUNWDGcXy3aDZbXKvkts9nEhxKMMimV1cZmVyz9Q8jlLCBYPXN+WQ1OTllpbqQK1s+5 DUOEmgG8JF7m5A3kNFhAqaYRNdPR6JXb07WsuCAAqThEe0KE3CQOYjRlHB5JcsekQazW ABFCFyMAzbPblgE/evUxmLwGVShM55HY3MyDBkhlIaaPNIWhwumNFRwJY4K+CSJrIU/M mL/2EvSIQzQHatQs5qBiJPQ7qwXjN+I/sxVvaSNMPum/TTmt65XF7VNKk211ASy1AvlO Qpqg== X-Gm-Message-State: AOAM530upgOnUfxSVqOYUyoPyMtkDKItLcfdjd1tD7HIYRaxcaQVYCkT XcJDsQIBeP6URVXoa1RpGZg8 X-Google-Smtp-Source: ABdhPJwCxa7n3N2IQRg6LXTIhA76NLNBlBqFee+u+GuUOaJ509tU02AxKJ+XNItcF5t2ZB5HPixdjA== X-Received: by 2002:a17:90b:110a:b0:1b9:eb62:7c00 with SMTP id gi10-20020a17090b110a00b001b9eb627c00mr19837163pjb.67.1645421719824; Sun, 20 Feb 2022 21:35:19 -0800 (PST) Received: from thinkpad ([220.158.158.223]) by smtp.gmail.com with ESMTPSA id b22-20020a17090a10d600b001b8e6841ca5sm6019443pje.51.2022.02.20.21.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 21:35:19 -0800 (PST) Date: Mon, 21 Feb 2022 11:05:14 +0530 From: Manivannan Sadhasivam To: Rohit Agarwal Cc: agross@kernel.org, bjorn.andersson@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, jassisinghbrar@gmail.com, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/7] mailbox: qcom: Add support for SDX65 APCS IPC Message-ID: <20220221053514.GA15108@thinkpad> References: <1645420953-21176-1-git-send-email-quic_rohiagar@quicinc.com> <1645420953-21176-3-git-send-email-quic_rohiagar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1645420953-21176-3-git-send-email-quic_rohiagar@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Feb 21, 2022 at 10:52:28AM +0530, Rohit Agarwal wrote: > In SDX65, the IPC bits are located in the APCS GCC block. Also, this block > can provide clock functionality. Hence, add support for IPC with correct > offset and name of the clock provider. > > Signed-off-by: Rohit Agarwal > --- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > index 9325d2a..54d7659 100644 > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > @@ -53,6 +53,10 @@ static const struct qcom_apcs_ipc_data sdx55_apcs_data = { > .offset = 0x1008, .clk_name = "qcom-sdx55-acps-clk" > }; > > +static const struct qcom_apcs_ipc_data sdx65_apcs_data = { > + .offset = 0x1008, .clk_name = "qcom-sdx55-acps-clk" > +}; What I suggested was reusing the "qcom,sdx55-apcs-gcc" compatible in devicetree. So with that, you won't need this specific compatible for SDX65 that essentially duplicates SDX55. Thanks, Mani > + > static const struct regmap_config apcs_regmap_config = { > .reg_bits = 32, > .reg_stride = 4, > @@ -159,6 +163,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = { > { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data }, > { .compatible = "qcom,sm6115-apcs-hmss-global", .data = &msm8994_apcs_data }, > { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data }, > + { .compatible = "qcom,sdx65-apcs-gcc", .data = &sdx65_apcs_data }, > {} > }; > MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match); > -- > 2.7.4 >