Devicetree
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Drew Fustini <dfustini@baylibre.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Dave Gerlach" <d-gerlach@ti.com>,
	devicetree@vger.kernel.org, Keerthy <j-keerthy@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-remoteproc@vger.kernel.org,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	s-anna@ti.com, khilman@baylibre.com
Subject: Re: [PATCH 02/11] dt-bindings: wkup_m3_ipc: Add vtt toggling bindings
Date: Mon, 21 Feb 2022 06:55:22 -0600	[thread overview]
Message-ID: <20220221125522.l3tntb6i7yjxp6vb@flattered> (raw)
In-Reply-To: <20220219215328.485660-3-dfustini@baylibre.com>

On 13:53-20220219, Drew Fustini wrote:
> From: Dave Gerlach <d-gerlach@ti.com>
> 
> Add description of the wkup_m3_ipc DT properties that can be used to
> toggle VTT regulator during low power mode transitions.
> 
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
>  .../bindings/soc/ti/wkup_m3_ipc.txt           | 34 +++++++++++++++++++


NAK. no more txt files please. convert to yaml prior to adding features.

>  1 file changed, 34 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/wkup_m3_ipc.txt b/Documentation/devicetree/bindings/soc/ti/wkup_m3_ipc.txt
> index 401550487ed6..4cdbb60fd0d0 100644
> --- a/Documentation/devicetree/bindings/soc/ti/wkup_m3_ipc.txt
> +++ b/Documentation/devicetree/bindings/soc/ti/wkup_m3_ipc.txt
> @@ -55,3 +55,37 @@ Example:
>  			...
>  		};
>  	};
> +
> +Support for VTT Toggle
> +==================================
> +In order to enable the support for VTT toggle during Suspend/Resume
> +sequence needed by some boards (like AM335x EVM-SK & AM437x GP EVM),
> +the below DT properties are required. It is possible to toggle VTT
> +using one of two methods depending on the SoC being used, either
> +GPIO0 toggle (AM335x and AM437x), or any GPIO with DS_PAD_CONFIG
> +bits in the control module (AM437x only).
> +
> +VTT Toggle using GPIO0
> +----------------------------------
> +Supported by: AM335x and AM437x
> +Used on: AM335x EVM-SK
> +
> +Optional properties:
> +- ti,needs-vtt-toggle:	Indicates that the boards requires VTT toggling
> +			during suspend/resume.
> +- ti,vtt-gpio-pin:	Specifies the GPIO0 pin used for VTT toggle.
> +
> +Important Note:
> +- Here it is assumed that VTT Toggle will be done using a pin on GPIO-0 Instance.
> +  It will not work on any other GPIO using the above properties, regardless of
> +  which part is being used.
> +
> +Example:
> +	wkup_m3_ipc: wkup_m3_ipc@1324 {
> +		compatible = "ti,am3352-wkup-m3-ipc";
> +		...
> +		...
> +		ti,needs-vtt-toggle;
> +		ti,vtt-gpio-pin = <7>;
> +		...
> +	};
> -- 
> 2.32.0
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2022-02-21 12:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19 21:53 [PATCH 00/11] soc: ti: wkup_m3_ipc: support vtt toggle, io isolation & voltage scaling Drew Fustini
2022-02-19 21:53 ` [PATCH 01/11] remoteproc: move rproc_da_to_va declaration to remoteproc.h Drew Fustini
2022-02-19 21:53 ` [PATCH 02/11] dt-bindings: wkup_m3_ipc: Add vtt toggling bindings Drew Fustini
2022-02-21 12:55   ` Nishanth Menon [this message]
2022-02-19 21:53 ` [PATCH 03/11] soc: ti: wkup_m3_ipc: Add support for toggling VTT regulator Drew Fustini
2022-02-19 21:53 ` [PATCH 04/11] dt-bindings: wkup_m3_ipc: Add ti,io-isolation property Drew Fustini
2022-02-19 21:53 ` [PATCH 05/11] soc: ti: wkup_m3_ipc: Add support for IO Isolation Drew Fustini
2022-02-19 21:53 ` [PATCH 06/11] ARM: dts: am437x-gp-evm: Enable wkup_m3 control of IO isolation Drew Fustini
2022-02-19 21:53 ` [PATCH 07/11] dt-bindings: wkup_m3_ipc: Add scale-data-fw property Drew Fustini
2022-02-19 21:53 ` [PATCH 08/11] soc: ti: wkup_m3_ipc: Add support for i2c voltage scaling Drew Fustini
2022-02-19 21:53 ` [PATCH 09/11] ARM: dts: am33xx: Add scale data fw to wkup_m3_ipc node Drew Fustini
2022-02-19 21:53 ` [PATCH 10/11] ARM: dts: am43xx: " Drew Fustini
2022-02-19 21:53 ` [PATCH 11/11] soc: ti: wkup_m3_ipc: Add debug option to halt m3 in suspend Drew Fustini
2022-02-21 12:58 ` [PATCH 00/11] soc: ti: wkup_m3_ipc: support vtt toggle, io isolation & voltage scaling Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220221125522.l3tntb6i7yjxp6vb@flattered \
    --to=nm@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dfustini@baylibre.com \
    --cc=j-keerthy@ti.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox