From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76CE3C43217 for ; Mon, 21 Feb 2022 13:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358744AbiBUNO6 (ORCPT ); Mon, 21 Feb 2022 08:14:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358791AbiBUNOy (ORCPT ); Mon, 21 Feb 2022 08:14:54 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39DF21EEE0; Mon, 21 Feb 2022 05:14:28 -0800 (PST) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 21LDDfnW088797; Mon, 21 Feb 2022 07:13:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1645449221; bh=vXu1G0emev+TnkGG5qABAZXlSG+xfFg5QuWYDC2AHek=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Dsv0NFIKFcID9DYTIhgmbO2DQxxSezhh1ln6oR81gCTGWrdNBtZdwVr6RXFw0Zu+D b0h2t3fENlvfOJnnHPQW02XoYC9hDG1fbYEE0q8uOdf/GQ3eLloxdoTVIzGVOpsHrF jPBp3q/6mkYDibbPuzFybwbnJyfSz9WIkaQN4Lg0= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 21LDDfnC096479 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Feb 2022 07:13:41 -0600 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 21 Feb 2022 07:13:40 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 21 Feb 2022 07:13:40 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 21LDDeog070333; Mon, 21 Feb 2022 07:13:40 -0600 Date: Mon, 21 Feb 2022 07:13:40 -0600 From: Nishanth Menon To: Krzysztof Kozlowski CC: Alim Akhtar , Avri Altman , Rob Herring , Wei Xu , Andy Gross , Bjorn Andersson , Vignesh Raghavendra , Tero Kristo , "James E.J. Bottomley" , "Martin K. Petersen" , Chanho Park , Srinivas Kandagatla , Jan Kotas , , , , , , Subject: Re: [RFC PATCH 8/8] arm64: dts: ti: use 'freq-table' in UFS node Message-ID: <20220221131340.q3hjpjevqrfvhggv@specimen> References: <20220219184224.44339-1-krzysztof.kozlowski@canonical.com> <20220219184554.44887-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220219184554.44887-1-krzysztof.kozlowski@canonical.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19:45-20220219, Krzysztof Kozlowski wrote: > The 'freq-table-hz' property is deprecated by UFS bindings. > The uint32-array requires also element to be passed within one <> block. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index 599861259a30..c3afef0321ae 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -1257,7 +1257,9 @@ ufs@4e84000 { > compatible = "cdns,ufshc-m31-16nm", "jedec,ufs-2.0"; > reg = <0x0 0x4e84000 0x0 0x10000>; > interrupts = ; > - freq-table-hz = <250000000 250000000>, <19200000 19200000>, <19200000 19200000>; > + freq-table = <250000000 250000000 is much more readable and less error prone in case of a large set. > + 19200000 19200000 > + 19200000 19200000>; are you sure the removal of the tuple adds value? > clocks = <&k3_clks 277 0>, <&k3_clks 277 1>, <&k3_clks 277 1>; > clock-names = "core_clk", "phy_clk", "ref_clk"; > dma-coherent; > -- > 2.32.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D