From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E03C433EF for ; Tue, 22 Feb 2022 02:14:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbiBVCOo (ORCPT ); Mon, 21 Feb 2022 21:14:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238432AbiBVCOn (ORCPT ); Mon, 21 Feb 2022 21:14:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD58415A17 for ; Mon, 21 Feb 2022 18:14:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A5E1614BE for ; Tue, 22 Feb 2022 02:14:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9409BC340E9; Tue, 22 Feb 2022 02:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645496056; bh=W10t9pBFl/Qpk+AaFC7B2lcPTz+UcEoj3rAESOoyJpQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fYNb2J/ImTjETrTKkswqrqa4v65JvrM/zCTqPDwg0T1tmYHzBOVdiF3Wm1Gtfqtkv LHXfWU80FLANV7EsQEwVs6+69nxnpZPMfTilkxAkxOAGFpbymdzdC92CgHhH4JRhAN urawu/8p+x5kaQH3tmICQXDn8g2nMKNPRckZKgHjbsXQ+veAX7Uwo4yRrZnSbh62BI or+c17UFTXAT+AsmUtpMQ3w7ayixJcdrDaYm6zETZt56QzLvecadJjsdrIohVNjo7L zQbiEt56zdaEt6IunliJPYX/OcoEZ3Rglnr6/IFv/ZPqkQWamNEUCxwZeI9BfE7vDk JqOtpyEj+Q1xA== Date: Tue, 22 Feb 2022 10:14:10 +0800 From: Shawn Guo To: Alexander Stein Cc: Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Fabio Estevam , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: (EXT) Re: [PATCH 2/5] ARM: dts: imx6ul: add TQ-Systems MBa6ULx device trees Message-ID: <20220222021410.GU2249@dragon> References: <20220208134223.908757-1-alexander.stein@ew.tq-group.com> <20220208134223.908757-3-alexander.stein@ew.tq-group.com> <20220213031211.GJ4909@dragon> <2816666.e9J7NaK4W3@steina-w> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2816666.e9J7NaK4W3@steina-w> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Feb 21, 2022 at 04:45:58PM +0100, Alexander Stein wrote: ... > > > diff --git a/arch/arm/boot/dts/mba6ulx.dtsi > > > b/arch/arm/boot/dts/mba6ulx.dtsi new file mode 100644 > > > index 000000000000..3a35b1efdc1f > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/mba6ulx.dtsi > > > @@ -0,0 +1,615 @@ > > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) > > > +/* > > > + * Copyright 2018-2022 TQ-Systems GmbH > > > + * Author: Markus Niebel > > > + */ > > > + > > > +/ { > > > + model = "TQ-Systems MBA6ULx Baseboard"; > > > + > > > + aliases { > > > + mmc0 = &usdhc2; > > > + mmc1 = &usdhc1; > > > + rtc0 = &rtc0; > > > + rtc1 = &snvs_rtc; > > > + }; > > > + > > > + backlight: backlight { > > > + compatible = "pwm-backlight"; > > > + power-supply = <®_mba6ul_3v3>; > > > + enable-gpios = <&expander_out0 4 GPIO_ACTIVE_HIGH>; > > > + status = "disabled"; > > > + }; > > > + > > > + beeper: beeper { > > > + compatible = "gpio-beeper"; > > > + gpios = <&expander_out1 6 GPIO_ACTIVE_HIGH>; > > > + }; > > > + > > > + chosen { > > > + stdout-path = &uart1; > > > + }; > > > > Move 'chosen' node up. > > Ok. The binding does not say anything regarding the order with respect to the > alias node. I've seen examples of both order. So I went with alias 1st, chosen > 2nd. Sorry for not being clear, but I was asking to put 'chosen' before backlight and beeper nodes. Shawn