From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8EA6C433F5 for ; Tue, 22 Feb 2022 20:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233004AbiBVU2j (ORCPT ); Tue, 22 Feb 2022 15:28:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231694AbiBVU2i (ORCPT ); Tue, 22 Feb 2022 15:28:38 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7649B16C6; Tue, 22 Feb 2022 12:28:10 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id A5FE61F4305C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645561689; bh=XYnec0KXZAvsEu9FVDIA+DCNqtz7GcNyNM0dZi5nGKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AQiUjtKxRYO1xX9vVoOOFXkPFSCC67v1ZQxPvDobu4gWR7S//0ksNk3esKGbhVuXp kkybtmOoMYucr4ZC4eBN8+PeME0ZM5h+wNE5jlPY5T3Ek0ktTMD57SSphD/bUYi83h oSvqbbit0Wx3GY23pOda1i/ImLhxByL6Mjc3J9W5tOCTsWn/U3lK0lq579nvZhsEBr 7vtTRzcVV8L5wBeZI8Nvp0xbrG1sjiWotqPbE2KehW+LSuoOVy0FNzqIy+PBtpLmja z5+JJx0Ai8AM+CipiokKTlJvCmNjdeaEPE8YrNTDWyAQnZ3eLjQFJlAdlrBVDVkofZ sFEWANLIa6NOw== Date: Tue, 22 Feb 2022 15:28:03 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Allen-KH Cheng Cc: Matthias Brugger , Rob Herring , --to=Krzysztof Kozlowski , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , Ryder Lee Subject: Re: [PATCH v2 07/23] arm64: dts: mt8192: Add xhci node Message-ID: <20220222202803.7mkskda3nsjrunpx@notapiano> References: <20220218091633.9368-1-allen-kh.cheng@mediatek.com> <20220218091633.9368-8-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220218091633.9368-8-allen-kh.cheng@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Feb 18, 2022 at 05:16:17PM +0800, Allen-KH Cheng wrote: > Add xhci node for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 25 ++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index ce18d692175f..08c7c1c772f5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > > / { > @@ -718,6 +719,30 @@ > status = "disabled"; > }; > > + xhci: xhci@11200000 { According to Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml, this node should be called usb (but the label can be kept as xhci). > + compatible = "mediatek,mt8192-xhci", > + "mediatek,mtk-xhci"; > + reg = <0 0x11200000 0 0x1000>, > + <0 0x11203e00 0 0x0100>; > + reg-names = "mac", "ippc"; > + interrupts-extended = <&gic GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH 0>; > + interrupt-names = "host"; > + phys = <&u2port0 PHY_TYPE_USB2>, > + <&u3port0 PHY_TYPE_USB3>; > + assigned-clocks = <&topckgen CLK_TOP_USB_TOP_SEL>, > + <&topckgen CLK_TOP_SSUSB_XHCI_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D5_D4>, > + <&topckgen CLK_TOP_UNIVPLL_D5_D4>; > + clocks = <&infracfg CLK_INFRA_SSUSB>, > + <&infracfg CLK_INFRA_SSUSB_XHCI>, > + <&apmixedsys CLK_APMIXED_USBPLL>; > + clock-names = "sys_ck", "xhci_ck", "ref_ck"; > + wakeup-source; > + mediatek,syscon-wakeup = <&pericfg 0x420 102>; > + #address-cells = <2>; > + #size-cells = <2>; This node doesn't have any children, so no need for #address-cells and #size-cells, just drop them. Also, let's keep this node disabled by default: status = "disabled"; > + }; > + > nor_flash: spi@11234000 { > compatible = "mediatek,mt8192-nor"; > reg = <0 0x11234000 0 0xe0>; > -- > 2.18.0 > >