From: Nishanth Menon <nm@ti.com>
To: Aparna M <a-m1@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<praneeth@ti.com>, <grygorii.strashko@ti.com>, <nikhil.nd@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
Date: Wed, 23 Feb 2022 10:36:40 -0600 [thread overview]
Message-ID: <20220223163640.flnyrxp33rpadevr@unable> (raw)
In-Reply-To: <20220223161850.5kpotstxkadbefp2@ti.com>
On 21:48-20220223, Aparna M wrote:
> On 07:55-20220223, Nishanth Menon wrote:
> > On 14:02-20220223, Aparna M wrote:
> > > AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
> > > gpio leds.
> > >
> > > Signed-off-by: Aparna M <a-m1@ti.com>
> > > ---
> > > arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
> > > 1 file changed, 70 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > > index 6b04745147be..31e45bafa49e 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > [...]
> >
> > > +
> > > + exp2: gpio@60 {
> > > + compatible = "ti,tpic2810";
> >
> > Sorry, but no.
> > please convert
> > Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt to yaml
> >
> > prior to any patches that enable it. (dtbs_check should have already
> > warned you about this).
>
> A patch for changing binding to yaml has already been sent.
> Link to patchwork: https://patchwork.ozlabs.org/project/linux-gpio/patch/20220223072308.31868-1-a-m1@ti.com/
you have errors that you need to address. once the patch gets to
mainline master branch, then we can consider this patch.
Also in the future, when there is dependency such as these, you should
indicate that in the diffstat section rather than expecting maintainers
to go searching (we wont).
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2022-02-23 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 8:32 [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs Aparna M
2022-02-23 13:55 ` Nishanth Menon
2022-02-23 16:18 ` Aparna M
2022-02-23 16:36 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223163640.flnyrxp33rpadevr@unable \
--to=nm@ti.com \
--cc=a-m1@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.nd@ti.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).