From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE12C433EF for ; Wed, 23 Feb 2022 16:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239792AbiBWQhT (ORCPT ); Wed, 23 Feb 2022 11:37:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242923AbiBWQhQ (ORCPT ); Wed, 23 Feb 2022 11:37:16 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1045042A28; Wed, 23 Feb 2022 08:36:47 -0800 (PST) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 21NGafAY077353; Wed, 23 Feb 2022 10:36:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1645634201; bh=in3TC9SWZxXkPfN5YzyeAC3zj+u+V0LbsNAukpto3ig=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=ZD/90e+vyg7c7KmsGAhdOYBzFaRw3194pN5uCDaHBAI11dUMfplB0DUb3OTsvy1Dz dUIWojf/ahSK/6kGGCk5L+jMMQcNnTbnsHOy5Pelmj+W+c5w4BGcB7jUGS3Z4ygSWk nhkSXOpcJQ/YwCB1I14Yh/3HY/IsFQSS3nisF57o= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 21NGafh3084362 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 23 Feb 2022 10:36:41 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 23 Feb 2022 10:36:40 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 23 Feb 2022 10:36:40 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 21NGaeD3130476; Wed, 23 Feb 2022 10:36:40 -0600 Date: Wed, 23 Feb 2022 10:36:40 -0600 From: Nishanth Menon To: Aparna M CC: , , , , , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs Message-ID: <20220223163640.flnyrxp33rpadevr@unable> References: <20220223083229.8044-1-a-m1@ti.com> <20220223135534.jbmbdvc4zye7udmc@grafting> <20220223161850.5kpotstxkadbefp2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220223161850.5kpotstxkadbefp2@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21:48-20220223, Aparna M wrote: > On 07:55-20220223, Nishanth Menon wrote: > > On 14:02-20220223, Aparna M wrote: > > > AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these > > > gpio leds. > > > > > > Signed-off-by: Aparna M > > > --- > > > arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++ > > > 1 file changed, 70 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts > > > index 6b04745147be..31e45bafa49e 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts > > [...] > > > > > + > > > + exp2: gpio@60 { > > > + compatible = "ti,tpic2810"; > > > > Sorry, but no. > > please convert > > Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt to yaml > > > > prior to any patches that enable it. (dtbs_check should have already > > warned you about this). > > A patch for changing binding to yaml has already been sent. > Link to patchwork: https://patchwork.ozlabs.org/project/linux-gpio/patch/20220223072308.31868-1-a-m1@ti.com/ you have errors that you need to address. once the patch gets to mainline master branch, then we can consider this patch. Also in the future, when there is dependency such as these, you should indicate that in the diffstat section rather than expecting maintainers to go searching (we wont). -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D