* [PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192
@ 2022-02-17 13:56 Allen-KH Cheng
2022-02-17 14:40 ` AngeloGioacchino Del Regno
2022-02-23 17:35 ` Nícolas F. R. A. Prado
0 siblings, 2 replies; 3+ messages in thread
From: Allen-KH Cheng @ 2022-02-17 13:56 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, Greg Kroah-Hartman,
Kishon Vijay Abraham I, Vinod Koul, Krzysztof Kozlowski
Cc: Chunfeng Yun, Min Guo, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Allen-KH Cheng
This commit adds dt-binding documentation of T-Phy for Mediatek MT8192 SoC
Platform.
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
index d279ba222316..7b2e1bc119be 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
@@ -81,6 +81,7 @@ properties:
- mediatek,mt7629-tphy
- mediatek,mt8183-tphy
- mediatek,mt8186-tphy
+ - mediatek,mt8192-tphy
- const: mediatek,generic-tphy-v2
- items:
- enum:
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192
2022-02-17 13:56 [PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192 Allen-KH Cheng
@ 2022-02-17 14:40 ` AngeloGioacchino Del Regno
2022-02-23 17:35 ` Nícolas F. R. A. Prado
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-02-17 14:40 UTC (permalink / raw)
To: Allen-KH Cheng, Matthias Brugger, Rob Herring, Greg Kroah-Hartman,
Kishon Vijay Abraham I, Vinod Koul, Krzysztof Kozlowski
Cc: Chunfeng Yun, Min Guo, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Il 17/02/22 14:56, Allen-KH Cheng ha scritto:
> This commit adds dt-binding documentation of T-Phy for Mediatek MT8192 SoC
> Platform.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index d279ba222316..7b2e1bc119be 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -81,6 +81,7 @@ properties:
> - mediatek,mt7629-tphy
> - mediatek,mt8183-tphy
> - mediatek,mt8186-tphy
> + - mediatek,mt8192-tphy
> - const: mediatek,generic-tphy-v2
> - items:
> - enum:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192
2022-02-17 13:56 [PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192 Allen-KH Cheng
2022-02-17 14:40 ` AngeloGioacchino Del Regno
@ 2022-02-23 17:35 ` Nícolas F. R. A. Prado
1 sibling, 0 replies; 3+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-02-23 17:35 UTC (permalink / raw)
To: Allen-KH Cheng
Cc: Matthias Brugger, Rob Herring, Greg Kroah-Hartman,
Kishon Vijay Abraham I, Vinod Koul, Krzysztof Kozlowski,
Chunfeng Yun, Min Guo, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Hi Allen,
thanks for the patch. Please see the comment below.
On Thu, Feb 17, 2022 at 09:56:20PM +0800, Allen-KH Cheng wrote:
> This commit adds dt-binding documentation of T-Phy for Mediatek MT8192 SoC
> Platform.
Commit messages should be in imperative [1]. I'd suggest the following message:
Add MT8192 compatible to the Mediatek T-PHY dt-binding.
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Also, the commit title would be better if it had the tag for the tphy file, like
this:
dt-bindings: phy: mediatek,tphy: Add compatible for MT8192
Otherwise it's not clear that you're changing the T-PHY just from the title.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Other than that,
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
> ---
> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index d279ba222316..7b2e1bc119be 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -81,6 +81,7 @@ properties:
> - mediatek,mt7629-tphy
> - mediatek,mt8183-tphy
> - mediatek,mt8186-tphy
> + - mediatek,mt8192-tphy
> - const: mediatek,generic-tphy-v2
> - items:
> - enum:
> --
> 2.18.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-23 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-17 13:56 [PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192 Allen-KH Cheng
2022-02-17 14:40 ` AngeloGioacchino Del Regno
2022-02-23 17:35 ` Nícolas F. R. A. Prado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).