* [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs
@ 2022-02-23 21:05 Michael Walle
2022-02-23 21:05 ` [PATCH v1 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC Michael Walle
2022-02-24 7:29 ` [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Heiko Thiery
0 siblings, 2 replies; 4+ messages in thread
From: Michael Walle @ 2022-02-23 21:05 UTC (permalink / raw)
To: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: heiko.thiery, devicetree, linux-arm-kernel, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Shawn Guo, Michael Walle
Use the power signal names as given in the schematics of the reference
board.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index b4225cfcb6d9..eaa06f49aef5 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -41,7 +41,7 @@ pmic: pmic@25 {
regulators {
buck1: BUCK1{
- regulator-name = "BUCK1";
+ regulator-name = "VDD_ARM_0V9";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <2187500>;
regulator-boot-on;
@@ -50,7 +50,7 @@ buck1: BUCK1{
};
buck2: BUCK2 {
- regulator-name = "BUCK2";
+ regulator-name = "VDD_SOC";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <2187500>;
regulator-boot-on;
@@ -61,7 +61,7 @@ buck2: BUCK2 {
};
buck4: BUCK4{
- regulator-name = "BUCK4";
+ regulator-name = "VDD_3V3";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <3400000>;
regulator-boot-on;
@@ -69,7 +69,7 @@ buck4: BUCK4{
};
buck5: BUCK5{
- regulator-name = "BUCK5";
+ regulator-name = "VDD_1V8";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <3400000>;
regulator-boot-on;
@@ -77,7 +77,7 @@ buck5: BUCK5{
};
buck6: BUCK6 {
- regulator-name = "BUCK6";
+ regulator-name = "NVCC_DRAM_1V1";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <3400000>;
regulator-boot-on;
@@ -85,7 +85,7 @@ buck6: BUCK6 {
};
ldo1: LDO1 {
- regulator-name = "LDO1";
+ regulator-name = "NVCC_SNVS_1V8";
regulator-min-microvolt = <1600000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
@@ -93,7 +93,7 @@ ldo1: LDO1 {
};
ldo2: LDO2 {
- regulator-name = "LDO2";
+ regulator-name = "VDD_SNVS_0V8";
regulator-min-microvolt = <800000>;
regulator-max-microvolt = <1150000>;
regulator-boot-on;
@@ -101,7 +101,7 @@ ldo2: LDO2 {
};
ldo3: LDO3 {
- regulator-name = "LDO3";
+ regulator-name = "VDDA_1V8";
regulator-min-microvolt = <800000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
@@ -109,7 +109,7 @@ ldo3: LDO3 {
};
ldo4: LDO4 {
- regulator-name = "LDO4";
+ regulator-name = "VDD_PHY_1V2";
regulator-min-microvolt = <800000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
@@ -117,7 +117,7 @@ ldo4: LDO4 {
};
ldo5: LDO5 {
- regulator-name = "LDO5";
+ regulator-name = "NVCC_SD2";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC
2022-02-23 21:05 [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Michael Walle
@ 2022-02-23 21:05 ` Michael Walle
2022-02-24 7:29 ` [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Heiko Thiery
1 sibling, 0 replies; 4+ messages in thread
From: Michael Walle @ 2022-02-23 21:05 UTC (permalink / raw)
To: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: heiko.thiery, devicetree, linux-arm-kernel, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Shawn Guo, Michael Walle
Use the proper voltages as supported by the board instead of the ones
supported by the PMIC. The voltages were taken from both the schematic
of the 8MNANOLPD4-EVK eval board and the datasheet of the IMX8MN SoC.
Signed-off-by: Michael Walle <michael@walle.cc>
---
Please help review and test this. This was never tested on the actual
8MNANOLPD4-EVK because I don't have that board! Instead it is a
"byproduct" of the development of an devicetree for the 8MNANOD3L-EVK
which is quite similar except for the DDR voltage and the buck1
converter.
arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 34 ++++++++++----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index eaa06f49aef5..2bb0155ea018 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -42,8 +42,8 @@ pmic: pmic@25 {
regulators {
buck1: BUCK1{
regulator-name = "VDD_ARM_0V9";
- regulator-min-microvolt = <600000>;
- regulator-max-microvolt = <2187500>;
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <1000000>;
regulator-boot-on;
regulator-always-on;
regulator-ramp-delay = <3125>;
@@ -51,8 +51,8 @@ buck1: BUCK1{
buck2: BUCK2 {
regulator-name = "VDD_SOC";
- regulator-min-microvolt = <600000>;
- regulator-max-microvolt = <2187500>;
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <950000>;
regulator-boot-on;
regulator-always-on;
regulator-ramp-delay = <3125>;
@@ -62,32 +62,32 @@ buck2: BUCK2 {
buck4: BUCK4{
regulator-name = "VDD_3V3";
- regulator-min-microvolt = <600000>;
- regulator-max-microvolt = <3400000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
};
buck5: BUCK5{
regulator-name = "VDD_1V8";
- regulator-min-microvolt = <600000>;
- regulator-max-microvolt = <3400000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
buck6: BUCK6 {
regulator-name = "NVCC_DRAM_1V1";
- regulator-min-microvolt = <600000>;
- regulator-max-microvolt = <3400000>;
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
regulator-boot-on;
regulator-always-on;
};
ldo1: LDO1 {
regulator-name = "NVCC_SNVS_1V8";
- regulator-min-microvolt = <1600000>;
- regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
@@ -95,23 +95,23 @@ ldo1: LDO1 {
ldo2: LDO2 {
regulator-name = "VDD_SNVS_0V8";
regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <1150000>;
+ regulator-max-microvolt = <800000>;
regulator-boot-on;
regulator-always-on;
};
ldo3: LDO3 {
regulator-name = "VDDA_1V8";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
ldo4: LDO4 {
regulator-name = "VDD_PHY_1V2";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
regulator-boot-on;
regulator-always-on;
};
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs
2022-02-23 21:05 [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Michael Walle
2022-02-23 21:05 ` [PATCH v1 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC Michael Walle
@ 2022-02-24 7:29 ` Heiko Thiery
2022-02-24 8:54 ` Michael Walle
1 sibling, 1 reply; 4+ messages in thread
From: Heiko Thiery @ 2022-02-24 7:29 UTC (permalink / raw)
To: Michael Walle
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Shawn Guo
Hi,
Am Mi., 23. Feb. 2022 um 22:06 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Use the power signal names as given in the schematics of the reference
> board.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> index b4225cfcb6d9..eaa06f49aef5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> @@ -41,7 +41,7 @@ pmic: pmic@25 {
>
> regulators {
> buck1: BUCK1{
> - regulator-name = "BUCK1";
> + regulator-name = "VDD_ARM_0V9";
I think BUCK1 and BUCK2 are twisted here. This should be "VDD_SOC".
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <2187500>;
> regulator-boot-on;
> @@ -50,7 +50,7 @@ buck1: BUCK1{
> };
>
> buck2: BUCK2 {
> - regulator-name = "BUCK2";
> + regulator-name = "VDD_SOC";
And this should be "VDD_ARM_0V9".
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <2187500>;
> regulator-boot-on;
> @@ -61,7 +61,7 @@ buck2: BUCK2 {
> };
>
> buck4: BUCK4{
> - regulator-name = "BUCK4";
> + regulator-name = "VDD_3V3";
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> @@ -69,7 +69,7 @@ buck4: BUCK4{
> };
>
> buck5: BUCK5{
> - regulator-name = "BUCK5";
> + regulator-name = "VDD_1V8";
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> @@ -77,7 +77,7 @@ buck5: BUCK5{
> };
>
> buck6: BUCK6 {
> - regulator-name = "BUCK6";
> + regulator-name = "NVCC_DRAM_1V1";
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> @@ -85,7 +85,7 @@ buck6: BUCK6 {
> };
>
> ldo1: LDO1 {
> - regulator-name = "LDO1";
> + regulator-name = "NVCC_SNVS_1V8";
> regulator-min-microvolt = <1600000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> @@ -93,7 +93,7 @@ ldo1: LDO1 {
> };
>
> ldo2: LDO2 {
> - regulator-name = "LDO2";
> + regulator-name = "VDD_SNVS_0V8";
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <1150000>;
> regulator-boot-on;
> @@ -101,7 +101,7 @@ ldo2: LDO2 {
> };
>
> ldo3: LDO3 {
> - regulator-name = "LDO3";
> + regulator-name = "VDDA_1V8";
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> @@ -109,7 +109,7 @@ ldo3: LDO3 {
> };
>
> ldo4: LDO4 {
> - regulator-name = "LDO4";
> + regulator-name = "VDD_PHY_1V2";
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> @@ -117,7 +117,7 @@ ldo4: LDO4 {
> };
>
> ldo5: LDO5 {
> - regulator-name = "LDO5";
> + regulator-name = "NVCC_SD2";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> --
> 2.30.2
>
--
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs
2022-02-24 7:29 ` [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Heiko Thiery
@ 2022-02-24 8:54 ` Michael Walle
0 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2022-02-24 8:54 UTC (permalink / raw)
To: Heiko Thiery
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Shawn Guo
Am 2022-02-24 08:29, schrieb Heiko Thiery:
> Hi,
>
> Am Mi., 23. Feb. 2022 um 22:06 Uhr schrieb Michael Walle
> <michael@walle.cc>:
>>
>> Use the power signal names as given in the schematics of the reference
>> board.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20
>> ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> index b4225cfcb6d9..eaa06f49aef5 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> @@ -41,7 +41,7 @@ pmic: pmic@25 {
>>
>> regulators {
>> buck1: BUCK1{
>> - regulator-name = "BUCK1";
>> + regulator-name = "VDD_ARM_0V9";
>
> I think BUCK1 and BUCK2 are twisted here. This should be "VDD_SOC".
>
>> regulator-min-microvolt = <600000>;
>> regulator-max-microvolt = <2187500>;
>> regulator-boot-on;
>> @@ -50,7 +50,7 @@ buck1: BUCK1{
>> };
>>
>> buck2: BUCK2 {
>> - regulator-name = "BUCK2";
>> + regulator-name = "VDD_SOC";
>
> And this should be "VDD_ARM_0V9".
You are absolutely right. I noticed it on the 8MNANOD3L-EVK but
forgot to update these.
-michael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-24 8:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-23 21:05 [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Michael Walle
2022-02-23 21:05 ` [PATCH v1 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC Michael Walle
2022-02-24 7:29 ` [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Heiko Thiery
2022-02-24 8:54 ` Michael Walle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).