From: Julius Werner <jwerner@chromium.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Julius Werner <jwerner@chromium.org>
Subject: [PATCH v3 1/3] dt-bindings: memory: lpddr2: Adjust revision ID property to match lpddr3
Date: Wed, 23 Feb 2022 16:34:19 -0800 [thread overview]
Message-ID: <20220224003421.3440124-2-jwerner@chromium.org> (raw)
In-Reply-To: <20220224003421.3440124-1-jwerner@chromium.org>
Commit 3539a2 (dt-bindings: memory: lpddr2: Add revision-id properties)
added the properties `revision-id1` and `revision-id2` to the
"jedec,lpddr2" binding. The "jedec,lpddr3" binding already had a single
array property `revision-id` for the same purpose. For consistency
between related memory types, this patch deprecates the LPDDR2
properties and instead adds a property in the same style as for LPDDR3
to that binding.
Signed-off-by: Julius Werner <jwerner@chromium.org>
---
.../memory-controllers/ddr/jedec,lpddr2.yaml | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
Changelog:
- v2:
- Updated commit message to fill in commit reference to earlier patch
- v3:
- Added `items` specification with `minimum` and `maximum` values to
`revision-id` binding
- Updated binding example to preserve previous revision ID values
diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
index 25ed0266f6dd3d..e9d0936861b779 100644
--- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
@@ -30,12 +30,26 @@ properties:
maximum: 255
description: |
Revision 1 value of SDRAM chip. Obtained from device datasheet.
+ Property is deprecated, use revision-id instead.
+ deprecated: true
revision-id2:
$ref: /schemas/types.yaml#/definitions/uint32
maximum: 255
description: |
Revision 2 value of SDRAM chip. Obtained from device datasheet.
+ Property is deprecated, use revision-id instead.
+ deprecated: true
+
+ revision-id:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description: |
+ Revision IDs read from Mode Register 6 and 7. One byte per uint32 cell (i.e. <MR6 MR7>).
+ minItems: 2
+ maxItems: 2
+ items:
+ minimum: 0
+ maximum: 255
density:
$ref: /schemas/types.yaml#/definitions/uint32
@@ -164,8 +178,7 @@ examples:
compatible = "elpida,ECB240ABACN", "jedec,lpddr2-s4";
density = <2048>;
io-width = <32>;
- revision-id1 = <1>;
- revision-id2 = <0>;
+ revision-id = <1 0>;
tRPab-min-tck = <3>;
tRCD-min-tck = <3>;
--
2.31.0
next prev parent reply other threads:[~2022-02-24 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 0:34 [PATCH 0/3] Update lpddr2 revision-id binding to match lpddr3 Julius Werner
2022-02-24 0:34 ` Julius Werner [this message]
2022-02-24 20:24 ` [PATCH v3 1/3] dt-bindings: memory: lpddr2: Adjust revision ID property " Rob Herring
2022-02-25 12:35 ` Krzysztof Kozlowski
2022-02-24 0:34 ` [PATCH 2/3] memory: Update of_memory lpddr2 revision-id binding Julius Werner
2022-02-24 0:34 ` [PATCH 3/3] ARM: dts: Update jedec,lpddr2 " Julius Werner
2022-02-24 7:29 ` Krzysztof Kozlowski
2022-02-24 12:38 ` Thierry Reding
2022-02-25 1:41 ` Julius Werner
2022-02-25 7:08 ` Krzysztof Kozlowski
2022-02-25 12:37 ` [PATCH 0/3] Update lpddr2 revision-id binding to match lpddr3 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224003421.3440124-2-jwerner@chromium.org \
--to=jwerner@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).