From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346D8C433FE for ; Thu, 24 Feb 2022 12:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233348AbiBXMux (ORCPT ); Thu, 24 Feb 2022 07:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232152AbiBXMuw (ORCPT ); Thu, 24 Feb 2022 07:50:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C73D51E2FEB for ; Thu, 24 Feb 2022 04:50:21 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNDZX-0003vB-8N; Thu, 24 Feb 2022 13:50:15 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nNDZT-0001tx-Fl; Thu, 24 Feb 2022 13:50:11 +0100 Date: Thu, 24 Feb 2022 13:50:11 +0100 From: Sascha Hauer To: Andy Yan Cc: Heiko =?iso-8859-15?Q?St=FCbner?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Message-ID: <20220224125011.GU9136@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217135823.GR18637@pengutronix.de> <6072461.kR79ftKOrO@diego> <8c0b1d1e-6787-8edc-c1fd-e1b68b92e60e@rock-chips.com> <20220218080024.GU18637@pengutronix.de> <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> <20220224081909.GS9136@pengutronix.de> <39f8f014-8d69-47e7-9004-b401ebb17e29@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <39f8f014-8d69-47e7-9004-b401ebb17e29@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 13:44:30 up 75 days, 21:30, 89 users, load average: 0.18, 0.25, 0.30 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Feb 24, 2022 at 06:54:35PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/24/22 16:19, Sascha Hauer wrote: > > On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 2/18/22 16:00, Sascha Hauer wrote: > > > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > > > > > Hi Sascha: > > > > > > > > > > On 2/17/22 22:06, Heiko Stübner wrote: > > > > > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > > > > > > > Hi Andy, > > > > > > > > > > > > > > Please trim the context in your answers to the relevant parts, it makes > > > > > > > it easier to find the things you said. > > > > > > > > > > > > > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > > > > > > > Hi Sascha: > > > > > > > > > > > > > > > > > + > > > > > > > > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->encoder_mask) { > > > > > > > > > + struct rockchip_encoder *rkencoder = to_rockchip_encoder(encoder); > > > > > > > > > + struct device_node *node, *parent; > > > > > > > > > + > > > > > > > > > + parent = of_get_parent(rkencoder->port); > > > > > > > > > + > > > > > > > > > + for_each_endpoint_of_node(parent, node) { > > > > > > > > Is there any hurt directly use our downstream vendor kernel method here: use > > > > > > > > vcstate->output_if set by encoder driver to get which interface we should > > > > > > > > enable here? > > > > > > > There is no vcstate->output_if in mainline currently. Ok, we could add > > > > > > > that. The other thing is that there are multiple HDMI interfaces and > > > > > > > the id of the HDMI encoder is encoded into output_if. Downstream kernel > > > > > > > adds OF aliases to the HDMI ports. I didn't want to go that route > > > > > > > because it doesn't seem to be very elegant to me. > > > > > aliases is a very comm strategy in device tree world. > > > > Yes, but not for retrieving bit offsets into registers. Normally aliases > > > > can be changed at board level without confusing drivers. > > > > > > > > > And your method also > > > > > add need additional dt binds to define RK3568_VOP2_EP_xxx > > > > > > > > You method is ok with device tree, but it tied up this driver to device > > > > > > > > tree, we are now tring to extend vop2 driver work with ACPI, so we hope this > > > > > > > > driver can be much more flexible. > > > > > > > The current rockchip drm driver seems to be pretty much tied to device > > > > > > > tree. There are probably many other places that need parallel paths for > > > > > > > ACPI support, I think we can delay this particular part until we see the > > > > > > > whole picture. In the end we can still retrieve the output_if > > > > > > > information differently with ACPI while still retrieving the information > > > > > > > from the device tree the way we are doing currently. > > > > > The current driver only reference device thee at driver initial, we not wrap > > > > > > > > > > device tree related things in other parts, so if we extend it to support > > > > > ACPI, > > > > > > > > > > we just need modify the initial code, this make things easier. > > > > The device tree parsing could be moved out of vop2_crtc_atomic_enable() > > > > into some initialisation path. In the end it's static information, > > > > there's no need to do it repeatedly in atomic_enable. > > > This could be one solution, the repeatedly parsing device tree in > > > atomic_enable is also my concern. > > > > > > In addition, there are 2 HDMI, 2 eDP, 2 MIPI on the coming rk3588, so it's > > > better to consider give position > > > > > > for HDMI1, EDP1, in  include/dt-bindings/soc/rockchip,vop2.h > > The defines are rk3568 specific. rk3588 would use a set of rk3588 > > specific defines along with a rk3588_set_intf_mux(). > > > Why not try to share these RK3568_VOP2_EP_XXX across all vop2 even vop based > rockchip socs? > > If make these definition RK3568 specific, we need copy all of it and change > 3568 to 3588 than add HDMI1, HDMI0, EDP1,EDP0 > > when rk3588 coming, if there is another rk35xx, we need to the same thing > again.... but they share same code logic and number, I can make the defines RK3568 agnostic and use ROCKCHIP_ as prefix. The actual numbers don't matter much, so we can add new interfaces or instances thereof at the end with the next free number. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |