From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05591C433EF for ; Fri, 25 Feb 2022 07:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238218AbiBYHow (ORCPT ); Fri, 25 Feb 2022 02:44:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234273AbiBYHow (ORCPT ); Fri, 25 Feb 2022 02:44:52 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA202272CF for ; Thu, 24 Feb 2022 23:44:20 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id o26so3274805pgb.8 for ; Thu, 24 Feb 2022 23:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pebQAfXF6XweYjs0eGI3bFR9spMrRG1FqYYUkNhfn+E=; b=Kl/dwA7J9l0gxrWs8kMoBqr+lcMx8XxtSxViisuumNbHcyG2PUWuPy3+a5v+k4wPxW Hv0eHcxH9z1uv+5779eWO9UV65SXJflq3eRoH531R/3kG35qboZIhDdFJhvGkg5hh+Rw oMYmH/tYn66ot8W98dH0/liRAWSshqbU7RjtWMIcg7vQDIB5zlDRsLYwJJpVSvE65WH2 /BqanM+9joXU9QGK6FPHIIOBtuw2CqmFaWdT36d/R3FEt45+8uLFzltsKshoQ3ofxO+o sXAfLGSrU79VemMHEXTCZVyYq6CSWkZRQdUZtFY/pWonsuew09I1qG3gb5k8MD3rwUoa WYNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pebQAfXF6XweYjs0eGI3bFR9spMrRG1FqYYUkNhfn+E=; b=tGQ3sFNqLV3V4N22Y1NRM6c9PcTSrA1fOid0VGkTHBW2zEPIb+l4Z9Va3aJGkbl1dK pikSd0GSEX9dgx1nKcKbjOWNtDwJSl+7mGNf2HsV9fyHC8guGwPfqzz84VeZOpct4a9H ZyNIGZQkWMAswQ9stQNtAQ+bETaTTIx6K80rsW7KwOaKw52wXZFzjq3pl0tXPMV7N8gz vSMlIbtc37+2QTDWD1bHMCixoYUh7JfEAYf+hVbXUOzwvP+crBidogMxXuiFtetS8ug5 erEqivo6OdeVf3tSbp7sG725yTF5Zk6NEkx4pBvP9lZp6izuSbydqiYKLOSCp6za+gBr pL8Q== X-Gm-Message-State: AOAM530YDxdnxeMx+R3ZTJCcPFBBko5b72H3ZfdJTNl31SQDBYKz96x0 1s0qyHaUHxUnYQ6XMv8b70lT X-Google-Smtp-Source: ABdhPJysLEw5Fe2Qq+cY1LBZd0c6mBCnomaQ6NxvOIVAGyd6cEKU6O+Dheso6fSjReAysM8+HH2yIA== X-Received: by 2002:a63:ba5e:0:b0:372:9bb2:c12d with SMTP id l30-20020a63ba5e000000b003729bb2c12dmr5253196pgu.380.1645775060237; Thu, 24 Feb 2022 23:44:20 -0800 (PST) Received: from thinkpad ([220.158.159.240]) by smtp.gmail.com with ESMTPSA id nn17-20020a17090b38d100b001bc5a705fb2sm1480029pjb.26.2022.02.24.23.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 23:44:19 -0800 (PST) Date: Fri, 25 Feb 2022 13:14:15 +0530 From: Manivannan Sadhasivam To: Rohit Agarwal Cc: Bjorn Andersson , agross@kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: qcom: Add chosen node information for SDX65. Message-ID: <20220225074415.GF274289@thinkpad> References: <1644574845-23248-1-git-send-email-quic_rohiagar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Feb 25, 2022 at 12:46:26PM +0530, Rohit Agarwal wrote: > > On 2/25/2022 1:14 AM, Bjorn Andersson wrote: > > On Fri 11 Feb 04:20 CST 2022, Rohit Agarwal wrote: > > > > > Add chosen node in the base dtsi file of SDX65. > > > > > While this happens to be the same on most boards, it is still a > > board-specific decision which UART is the debug uart, or if there is one > > at all... > > > > So this property should remain in the dts. > > > > Thanks, > > Bjorn > > Without the chosen node in base dtsi, the device is not booting up. > Can we have an empty chosen node in the base dtsi and the board-specific > details > updated in the respective dts file. The device boots up with this. > I believe this is something to do with bootloader. But still I don't understand how this matters at all since the bootloader finally parses the "dtb" only. Is the bootloader picking up correct dtb? Thanks, Mani > Thanks, > Rohit > > > > Signed-off-by: Rohit Agarwal > > > --- > > > arch/arm/boot/dts/qcom-sdx65-mtp.dts | 4 ---- > > > arch/arm/boot/dts/qcom-sdx65.dtsi | 4 ++++ > > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts > > > index 59457da..3a75c21 100644 > > > --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts > > > +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts > > > @@ -14,10 +14,6 @@ > > > aliases { > > > serial0 = &blsp1_uart3; > > > }; > > > - > > > - chosen { > > > - stdout-path = "serial0:115200n8"; > > > - }; > > > }; > > > &blsp1_uart3 { > > > diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi > > > index 796641d..653df15 100644 > > > --- a/arch/arm/boot/dts/qcom-sdx65.dtsi > > > +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi > > > @@ -17,6 +17,10 @@ > > > qcom,msm-id = <458 0x10000>, <483 0x10000>, <509 0x10000>; > > > interrupt-parent = <&intc>; > > > + chosen { > > > + stdout-path = "serial0:115200n8"; > > > + }; > > > + > > > memory { > > > device_type = "memory"; > > > reg = <0 0>; > > > -- > > > 2.7.4 > > >