From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CACC433F5 for ; Fri, 25 Feb 2022 08:40:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238567AbiBYIlH (ORCPT ); Fri, 25 Feb 2022 03:41:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238564AbiBYIlH (ORCPT ); Fri, 25 Feb 2022 03:41:07 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E06F252905 for ; Fri, 25 Feb 2022 00:40:35 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNW9B-0000ZC-UI; Fri, 25 Feb 2022 09:40:17 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nNW97-000720-Sx; Fri, 25 Feb 2022 09:40:13 +0100 Date: Fri, 25 Feb 2022 09:40:13 +0100 From: Oleksij Rempel To: Rob Herring Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , "David S. Miller" , Florian Fainelli , Jakub Kicinski , Krzysztof Kozlowski , Nicolas Saenz Julienne , Ray Jui , Sascha Hauer , Scott Branden , Shawn Guo , Tony Lindgren , kernel@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers Message-ID: <20220225084013.GA26647@pengutronix.de> References: <20220216074927.3619425-1-o.rempel@pengutronix.de> <20220216074927.3619425-3-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:37:59 up 76 days, 17:23, 84 users, load average: 0.25, 0.18, 0.18 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Feb 24, 2022 at 11:18:30AM -0600, Rob Herring wrote: > On Wed, Feb 16, 2022 at 08:49:20AM +0100, Oleksij Rempel wrote: > > +additionalProperties: false > > + > > +examples: > > + - | > > + usb { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethernet@1 { > > + compatible = "usb424,ec00"; > > If this is a hub/ethernet combo device, how is it valid to be standalone > without the hub? What is the best way to describe two type of devices: with and without hub in package? Have two different schema to keep things simple? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |