From: Jonathan Cameron <jic23@kernel.org>
To: Jagath Jog J <jagathjog1996@gmail.com>
Cc: lars@metafoo.de, andy.shevchenko@gmail.com, sst@poczta.fm,
robh+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/7] iio: potentiometer: Alignment to match the open parenthesis
Date: Sat, 26 Feb 2022 18:35:31 +0000 [thread overview]
Message-ID: <20220226183531.05f5f0be@jic23-huawei> (raw)
In-Reply-To: <20220223163525.13399-2-jagathjog1996@gmail.com>
On Wed, 23 Feb 2022 22:05:19 +0530
Jagath Jog J <jagathjog1996@gmail.com> wrote:
> Fix following checkpatch.pl check by removing blank space.
> CHECK: Alignment should match open parenthesis.
>
> Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
I didn't noticed before, but for future please put the driver name
in the patch titles!
iio: potentiometer: ds1803: xxxx
I'll fix up.
> ---
> drivers/iio/potentiometer/ds1803.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/potentiometer/ds1803.c b/drivers/iio/potentiometer/ds1803.c
> index 20b45407eaac..3c542a50ece6 100644
> --- a/drivers/iio/potentiometer/ds1803.c
> +++ b/drivers/iio/potentiometer/ds1803.c
> @@ -55,8 +55,8 @@ static const struct iio_chan_spec ds1803_channels[] = {
> };
>
> static int ds1803_read_raw(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - int *val, int *val2, long mask)
> + struct iio_chan_spec const *chan,
> + int *val, int *val2, long mask)
> {
> struct ds1803_data *data = iio_priv(indio_dev);
> int pot = chan->channel;
> @@ -66,7 +66,7 @@ static int ds1803_read_raw(struct iio_dev *indio_dev,
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
> ret = i2c_master_recv(data->client, result,
> - indio_dev->num_channels);
> + indio_dev->num_channels);
> if (ret < 0)
> return ret;
>
> @@ -83,8 +83,8 @@ static int ds1803_read_raw(struct iio_dev *indio_dev,
> }
>
> static int ds1803_write_raw(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - int val, int val2, long mask)
> + struct iio_chan_spec const *chan,
> + int val, int val2, long mask)
> {
> struct ds1803_data *data = iio_priv(indio_dev);
> int pot = chan->channel;
> @@ -109,8 +109,7 @@ static const struct iio_info ds1803_info = {
> .write_raw = ds1803_write_raw,
> };
>
> -static int ds1803_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ds1803_probe(struct i2c_client *client, const struct i2c_device_id *id)
> {
> struct device *dev = &client->dev;
> struct ds1803_data *data;
next prev parent reply other threads:[~2022-02-26 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 16:35 [PATCH v5 0/7] iio: potentiometer: Add support for DS3502 Jagath Jog J
2022-02-23 16:35 ` [PATCH v5 1/7] iio: potentiometer: Alignment to match the open parenthesis Jagath Jog J
2022-02-26 18:35 ` Jonathan Cameron [this message]
2022-02-23 16:35 ` [PATCH v5 2/7] iio: potentiometer: Add available functionality Jagath Jog J
2022-02-26 18:40 ` Jonathan Cameron
2022-02-23 16:35 ` [PATCH v5 3/7] iio: potentiometer: Add channel information in device data Jagath Jog J
2022-02-23 16:35 ` [PATCH v5 4/7] iio: potentiometer: Change to firmware provided data Jagath Jog J
2022-02-23 16:35 ` [PATCH v5 5/7] iio: potentiometer: Add device specific read_raw function Jagath Jog J
2022-02-24 0:46 ` Andy Shevchenko
2022-02-26 18:39 ` Jonathan Cameron
2022-02-23 16:35 ` [PATCH v5 6/7] iio: potentiometer: Add support for Maxim DS3502 Jagath Jog J
2022-02-23 16:35 ` [PATCH v5 7/7] dt-bindings: iio: potentiometer: Add Maxim DS3502 in trivial-devices Jagath Jog J
2022-02-24 0:47 ` [PATCH v5 0/7] iio: potentiometer: Add support for DS3502 Andy Shevchenko
2022-02-26 18:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220226183531.05f5f0be@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jagathjog1996@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox