From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, robh+dt@kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH v6 1/3] dt-bindings: iio: amplifiers: add ada4250 doc
Date: Sun, 27 Feb 2022 12:10:35 +0000 [thread overview]
Message-ID: <20220227121035.07a922a8@jic23-huawei> (raw)
In-Reply-To: <Yhey1QmZa4RU0p50@robh.at.kernel.org>
On Thu, 24 Feb 2022 10:31:17 -0600
Rob Herring <robh@kernel.org> wrote:
> On Wed, 23 Feb 2022 14:01:10 +0200, Antoniu Miclaus wrote:
> > Add device tree bindings for the ADA4250 driver.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> > changes in v6:
> > - add space before `{` in the amplifier node example
> > .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Series applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a quick look before I go making a mess of linux-next.
One side comment though - when there are lots of revisions in a short timescale
and people haven't had time to get back to the intermediate ones, it is particularly
helpful to give a multi version change log.
i.e. tell us what happened in at least the last couple of revisions to save
on having to go find the earlier threads to find out what changed in v5 and v4!
Also, I always prefer a cover letter for a series even if brief. It give somewhere
to reply to if there are discussions covering multiple patches, or if someone wants
to give a tag for the whole series that I can trivially pick up with b4.
Obviously no point for single patch series though!
I don't normally moan about this, but I was moaning anyway so why not get
everything off my chest! :)
Thanks,
Jonathan
prev parent reply other threads:[~2022-02-27 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 12:01 [PATCH v6 1/3] dt-bindings: iio: amplifiers: add ada4250 doc Antoniu Miclaus
2022-02-23 12:01 ` [PATCH v6 2/3] iio: amplifiers: ada4250: add support for ADA4250 Antoniu Miclaus
2022-02-23 12:01 ` [PATCH v6 3/3] MAINTAINERS: add maintainer for ADA4250 driver Antoniu Miclaus
2022-02-24 16:31 ` [PATCH v6 1/3] dt-bindings: iio: amplifiers: add ada4250 doc Rob Herring
2022-02-27 12:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220227121035.07a922a8@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox