devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Cristian Pop <cristian.pop@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v7 1/2] dt-bindings: iio: frequency: Add ADMV4420 doc
Date: Sun, 27 Feb 2022 12:21:45 +0000	[thread overview]
Message-ID: <20220227122145.6bc20b68@jic23-huawei> (raw)
In-Reply-To: <b591b26e-1a80-e17d-4525-989b357e97b1@canonical.com>

On Wed, 23 Feb 2022 14:26:05 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:

> On 23/02/2022 14:08, Cristian Pop wrote:
> > Add device tree bindings for the ADMV4420 K band downconverter.
> > 
> > Signed-off-by: Cristian Pop <cristian.pop@analog.com>
> > ---
> > Changes in v7:
> >  - Fix commit message  
> 
> Please include the tags accumulated in previous reviews.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> 
> Best regards,
> Krzysztof

Series applied to the togreg branch of iio.git and pushed out as testing
to let 0-day take a look before I go breaking linux-next (again :)

You get the same general feedback for future series as I just gave Antoniu:

1) Particularly when doing multiple revisions close together, please give
   a longer change log covering at least the last few versions as not
   everyone will have looked at v7 and it saves reviewers time otherwise
   spent checking back through earlier versions.
2) Cover letters are good for multipatch series because they both provide
   somewhere for general discussion that overlaps multiple patches and
   as somewhere for series wide tags to be given and that sometimes
   makes my life easier (complex cases where some tags are for individual
   patches and some are series wide which I have to go in an add by hand
   as no automated tool e.g. b4, could work it out!) 

Sometimes I like to complain about this trivial stuff that makes me
ever so slightly grumpy :)

Jonathan


  reply	other threads:[~2022-02-27 12:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 13:08 [PATCH v7 1/2] dt-bindings: iio: frequency: Add ADMV4420 doc Cristian Pop
2022-02-23 13:08 ` [PATCH v7 2/2] iio: frequency: admv4420.c: Add support for ADMV4420 Cristian Pop
2022-02-23 13:26 ` [PATCH v7 1/2] dt-bindings: iio: frequency: Add ADMV4420 doc Krzysztof Kozlowski
2022-02-27 12:21   ` Jonathan Cameron [this message]
2022-02-24 16:30 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220227122145.6bc20b68@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=cristian.pop@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).