From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH v4 1/3] iio: dac: add support for ltc2688
Date: Sun, 27 Feb 2022 12:38:25 +0000 [thread overview]
Message-ID: <20220227123825.3555f44f@jic23-huawei> (raw)
In-Reply-To: <20220225130129.69-2-nuno.sa@analog.com>
On Fri, 25 Feb 2022 14:01:27 +0100
Nuno Sá <nuno.sa@analog.com> wrote:
> The LTC2688 is a 16 channel, 16 bit, +-15V DAC with an integrated
> precision reference. It is guaranteed monotonic and has built in
> rail-to-rail output buffers that can source or sink up to 20 mA.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Just one comment below - not a suggestion to change anything at this
stage though, just something that might come up in future.
...
> +static const char * const ltc2688_dither_phase[] = {
> + "0", "1.5708", "3.14159", "4.71239",
> +};
> +
It if turns out we have in kernel users for this in the long run
we may need to change these over to numeric values, but we
can do that without changing the userspace ABI, so this is fine for
now.
...
Thanks,
Jonathan
next prev parent reply other threads:[~2022-02-27 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 13:01 [PATCH v4 0/3] Add support for LTC2688 Nuno Sá
2022-02-25 13:01 ` [PATCH v4 1/3] iio: dac: add support for ltc2688 Nuno Sá
2022-02-27 12:38 ` Jonathan Cameron [this message]
2022-02-25 13:01 ` [PATCH v4 2/3] iio: ABI: add ABI file for the LTC2688 DAC Nuno Sá
2022-02-25 13:01 ` [PATCH v4 3/3] dt-bindings: iio: Add ltc2688 documentation Nuno Sá
2022-02-27 12:49 ` [PATCH v4 0/3] Add support for LTC2688 Jonathan Cameron
2022-03-01 22:20 ` Jonathan Cameron
2022-03-02 19:54 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220227123825.3555f44f@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).