From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, <kernel@axis.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: virtual: add devicetree support
Date: Mon, 28 Feb 2022 16:50:27 +0100 [thread overview]
Message-ID: <20220228155027.GA16152@axis.com> (raw)
In-Reply-To: <YhZDVGC7dPiisnI+@sirena.org.uk>
On Wed, Feb 23, 2022 at 02:23:16PM +0000, Mark Brown wrote:
> On Fri, Feb 18, 2022 at 12:06:03PM +0100, Vincent Whitchurch wrote:
>
> > The reg-virt-consumer is very useful for development and testing of
> > regulator drivers since it allows voltages and modes to be set from
> > userspace. However, it currently requires platform data so it cannot be
> > used on modern platforms. Add support for probing it from the
> > devicetree to remedy this.
>
> Meh, you can add a bit of code on module_init() to register a platform
> device or something.
Something like that could work during manual testing, but I'm hoping to
use this from a test framework where it's rather impractical to patch
individual drivers in that way.
> > Since this driver is only meant for testing and is a purely software
> > construct, no binding documentation is added.
>
> That's not going to stop anyone. We should at the very least be
> printing very loud warnings if anyone tries to intantiate this.
I can add a warning. Maybe something like this, following the style of
kernel/trace/trace.c?
pr_warn("**********************************************************\n");
pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
pr_warn("** **\n");
pr_warn("** regulator-virtual-consumer is only for testing and **\n");
pr_warn("** debugging. Do not use it in a production kernel. **\n");
pr_warn("** **\n");
pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
pr_warn("**********************************************************\n");
>
> > + if (!reg_id)
> > + reg_id = "default";
> > +
>
> Oh?
As you know, this results in looking for the regulator phandle in a
property named "default-supply". I wasn't sure what supply name to use
for this virtual client. Getting the name from another property seemed
unnecessary. Would you prefer that, or would you suggest some other
name than "default"?
next prev parent reply other threads:[~2022-02-28 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 11:06 [PATCH] regulator: virtual: add devicetree support Vincent Whitchurch
2022-02-23 14:23 ` Mark Brown
2022-02-28 15:50 ` Vincent Whitchurch [this message]
2022-02-28 15:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228155027.GA16152@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).