From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04130C433EF for ; Tue, 1 Mar 2022 04:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231693AbiCAEH5 (ORCPT ); Mon, 28 Feb 2022 23:07:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232185AbiCAEH4 (ORCPT ); Mon, 28 Feb 2022 23:07:56 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EA864C416 for ; Mon, 28 Feb 2022 20:07:16 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id ge19-20020a17090b0e1300b001bcca16e2e7so1001296pjb.3 for ; Mon, 28 Feb 2022 20:07:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DaUtZIJE57Vq9SZxZBhHAxebl5xJ9yYYEaN9hQal+Yc=; b=zkOAS1NuNVVA37+a+9a5ZOpokz2S8PWO35PvVGMMThDauaYUOPsvyVjtc8Zr41iFQi evBontnp0ibEks/7mYoY/YuqsCVhfpUaez7NR3mQ0Sa4AfaUz3NIZ7rvzqT9zXMSljSt jicjvB603m34d1Vm7FPVEsF93+5HqkdpbTJlR8aaCL3RSFn22ck2ctV0flqmUD8K22aX rBn1xW1ZmBx4pBckCgQoMMVFxwuuIu4PoBfFW1nuuS6InmoX/5JQDMz3HQ8pbqIOzO/o WBivj9pQFfdMjgHIT5CIYTmXNNtOvZ+OWI1ZbDsQbvnZOWTjZM6+zR9aSqlKeFTtKg89 hDig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DaUtZIJE57Vq9SZxZBhHAxebl5xJ9yYYEaN9hQal+Yc=; b=i8o0NO7psgcVZMyl9ggMmlkNMp7yfT0mdnaXvrTpsC9y+nwjo2OaXTc5K00x/zwhnE 7M1JbMAOmd/hCTAC/q8cuQAgzu6LyYl9hcSIMPEzfwNKCO2fJfJ09/0rUXrr6XJKOVfH zKLJXAJessHTQR5ghIeh1lMP0/aOYE98IVwmuv3ttmVbGvhhFvNqgOJP8+9SwIuu+FY1 QQEMdykHZ3NkwvejhUzAtioa+b4j8x/aTDeVjOA2zT30F6wQ2fJcE/31yZgRZpnHnB0i T1BVpW+vQ6zf/3FbYU4uBUGFZuBr/7orhBurg8u1aXJBu2Eg8Hg825l5Ox8amDxCU38I scLQ== X-Gm-Message-State: AOAM5305iVKByJL3lJmYWwqFYFm9A7TRitjDm6Q22nLWwTFQ0bsoHV22 NJCNdrtmkaNL357YrYjIOWBJQZN6QrPs8Q== X-Google-Smtp-Source: ABdhPJzWqb7Tsc9wjdCtlNdc3HRUiLy0CedyQh9cebhriMji18nhdC0SewddXyCwWxQiEaQ3kO+ocg== X-Received: by 2002:a17:903:2448:b0:151:8173:abf5 with SMTP id l8-20020a170903244800b001518173abf5mr1730249pls.55.1646107636043; Mon, 28 Feb 2022 20:07:16 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id a32-20020a631a20000000b003756899829csm11509153pga.58.2022.02.28.20.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 20:07:15 -0800 (PST) Date: Tue, 1 Mar 2022 12:07:09 +0800 From: Shawn Guo To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, robh+dt@kernel.org, Bjorn Andersson , Rob Herring Subject: Re: [PATCH v2 7/8] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly Message-ID: <20220301040709.GF269879@dragon> References: <20220228123019.382037-1-bhupesh.sharma@linaro.org> <20220228123019.382037-8-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220228123019.382037-8-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Feb 28, 2022 at 06:00:18PM +0530, Bhupesh Sharma wrote: > Currently the qcom,qmp-phy dt-binding doesn't describe > the 'reg' and '#phy-cells' properties for the phy@ subnode. > > Fix the same. > > Cc: Bjorn Andersson > Cc: Rob Herring > Signed-off-by: Bhupesh Sharma > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index 70e7cd75e173..f8a43acd229a 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -115,6 +115,13 @@ patternProperties: > Each device node of QMP phy is required to have as many child nodes as > the number of lanes the PHY has. > properties: > + reg: > + minItems: 1 > + maxItems: 6 > + > + "#phy-cells": > + const: 0 > + > "#clock-cells": > enum: [ 0, 1, 2 ] While you are at it, what about these properties? clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; clock-names = "pipe0"; clock-output-names = "usb3_phy_pipe_clk_src"; Shawn