From: Steven Rostedt <rostedt@goodmis.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Chun-Tse Shao <ctshao@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Frank Rowand <frowand.list@gmail.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] config: Using HOSTPKG_CONFIG prefix for pkg-config
Date: Wed, 2 Mar 2022 10:27:05 -0500 [thread overview]
Message-ID: <20220302102705.15c32822@gandalf.local.home> (raw)
In-Reply-To: <CAL_JsqK59GGhYQSEWvb=HtHTwMh=LXomu2zX4dEQeo4s3A0VtQ@mail.gmail.com>
On Wed, 2 Mar 2022 08:18:15 -0600
Rob Herring <robh+dt@kernel.org> wrote:
> On Tue, Mar 1, 2022 at 5:07 PM Chun-Tse Shao <ctshao@google.com> wrote:
> >
> > In some parts, pkg-config does not use appropriate $BUILDROOT prefix.
>
> The kernel tree knows nothing about buildroot. Please reword this in a
> more generic way that you need to override the host pkg-config.
I don't even know what $BUILDROOT is ;-)
But I do know that it's good practice to allow pkg-config to be overridden.
I have several user space tools that needed it done to allow distros to
install them properly.
Would you be OK with a description like:
Allow kernel installation packaging to override pkg-config.
?
>
> > The patch adds HOSTPKG_CONFIG prefix for pkg-config to fix the issue.
A couple of things. It is consider poor form to reference "the patch".
Another thing is that this is not a prefix for pkg-config, it is overriding
what pkg-config is used during the build process.
Add HOSTPKG_CONFIG to allow tooling that builds the kernel to override
what pkg-config and parameters are used.
Something like that.
-- Steve
> >
> > Signed-off-by: Chun-Tse Shao <ctshao@google.com>
next prev parent reply other threads:[~2022-03-02 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 23:06 [PATCH] config: Using HOSTPKG_CONFIG prefix for pkg-config Chun-Tse Shao
2022-03-02 14:18 ` Rob Herring
2022-03-02 15:27 ` Steven Rostedt [this message]
2022-03-02 19:36 ` [PATCH v2] config: Allow kernel installation packaging to override pkg-config Chun-Tse Shao
2022-03-02 21:48 ` Nick Desaulniers
2022-03-03 12:42 ` Steven Rostedt
2022-03-03 18:41 ` Nick Desaulniers
2022-03-03 23:50 ` [PATCH v3] " Chun-Tse Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302102705.15c32822@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ctshao@google.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).