[PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property

[PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property

[Kuldeep Singh]

Broadcom ns2 platform has spi-cpol and spi-cpho properties set
incorrectly. As per spi-slave-peripheral-prop.yaml, these properties are
of flag or boolean type and not integer type. Fix the values.

CC: Ray Jui <rjui@broadcom.com>
CC: Scott Branden <sbranden@broadcom.com>
CC: Florian Fainelli <f.fainelli@gmail.com>
Fixes: d69dbd9f41a7c (arm64: dts: Add ARM PL022 SPI DT nodes for NS2)
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
Hi,

This patch is on top of git://github.com/broadcom/cygnus-linux.git,
master branch which is not updated since 4.14 kernel.
Hope the reference is correct. Thanks!


 arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
index ec19fbf928a1..12a4b1c03390 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
@@ -111,8 +111,8 @@
 		compatible = "silabs,si3226x";
 		reg = <0>;
 		spi-max-frequency = <5000000>;
-		spi-cpha = <1>;
-		spi-cpol = <1>;
+		spi-cpha;
+		spi-cpol;
 		pl022,hierarchy = <0>;
 		pl022,interface = <0>;
 		pl022,slave-tx-disable = <0>;
@@ -135,8 +135,8 @@
 		at25,byte-len = <0x8000>;
 		at25,addr-mode = <2>;
 		at25,page-size = <64>;
-		spi-cpha = <1>;
-		spi-cpol = <1>;
+		spi-cpha;
+		spi-cpol;
 		pl022,hierarchy = <0>;
 		pl022,interface = <0>;
 		pl022,slave-tx-disable = <0>;
-- 
2.25.1

Re: [PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property

[Florian Fainelli]

On 2/28/2022 3:09 AM, Kuldeep Singh wrote:
> Broadcom ns2 platform has spi-cpol and spi-cpho properties set
> incorrectly. As per spi-slave-peripheral-prop.yaml, these properties are
> of flag or boolean type and not integer type. Fix the values.
> 
> CC: Ray Jui <rjui@broadcom.com>
> CC: Scott Branden <sbranden@broadcom.com>
> CC: Florian Fainelli <f.fainelli@gmail.com>
> Fixes: d69dbd9f41a7c (arm64: dts: Add ARM PL022 SPI DT nodes for NS2)
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
> Hi,
> 
> This patch is on top of git://github.com/broadcom/cygnus-linux.git,
> master branch which is not updated since 4.14 kernel.
> Hope the reference is correct. Thanks!

The reference is not correct, but it applied cleanly anyway. The correct 
reference would have been the github.com/Broadcom/stblinux 
refs/heads/devicetree-arm64/next

Applied, thanks!
-- 
Florian

Re: [PATCH] arm64: dts: ns2: Fix spi-cpol and spi-cpha property

[Kuldeep Singh]

On Mon, Feb 28, 2022 at 01:31:50PM -0800, Florian Fainelli wrote:
> 
> 
> On 2/28/2022 3:09 AM, Kuldeep Singh wrote:
> > Broadcom ns2 platform has spi-cpol and spi-cpho properties set
> > incorrectly. As per spi-slave-peripheral-prop.yaml, these properties are
> > of flag or boolean type and not integer type. Fix the values.
> > 
> > CC: Ray Jui <rjui@broadcom.com>
> > CC: Scott Branden <sbranden@broadcom.com>
> > CC: Florian Fainelli <f.fainelli@gmail.com>
> > Fixes: d69dbd9f41a7c (arm64: dts: Add ARM PL022 SPI DT nodes for NS2)
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> > Hi,
> > 
> > This patch is on top of git://github.com/broadcom/cygnus-linux.git,
> > master branch which is not updated since 4.14 kernel.
> > Hope the reference is correct. Thanks!
> 
> The reference is not correct, but it applied cleanly anyway. The correct
> reference would have been the github.com/Broadcom/stblinux
> refs/heads/devicetree-arm64/next

Thanks Florian for mentioning.
I took a quick look at MAINTAINERS file before sending patch and found
cygnus-linux repo as base reference. It seems the correct reference is
not updated in MAINTAINERS file.

> 
> Applied, thanks!

Thanks!

-- 
Best Regards
Kuldeep