devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tyrone Ting <warp5tw@gmail.com>
To: avifishman70@gmail.com, tmaimon77@gmail.com,
	tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
	benjaminfair@google.com, robh+dt@kernel.org,
	krzysztof.kozlowski@canonical.com, yangyicong@hisilicon.com,
	semen.protsenko@linaro.org, wsa@kernel.org, jie.deng@intel.com,
	sven@svenpeter.dev, bence98@sch.bme.hu, lukas.bulwahn@gmail.com,
	arnd@arndb.de, olof@lixom.net, andriy.shevchenko@linux.intel.com,
	warp5tw@gmail.com, tali.perry@nuvoton.com,
	Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
	KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts
Date: Thu,  3 Mar 2022 16:31:30 +0800	[thread overview]
Message-ID: <20220303083141.8742-1-warp5tw@gmail.com> (raw)

From: Tyrone Ting <kfting@nuvoton.com>

This patchset includes the following fixes:

- Add dt-bindings description for NPCM845.
- Bug fix for timeout calculation.
- Better handling of spurious interrupts.
- Fix for event type in slave mode.
- Removal of own slave addresses [2:10].
- Support for next gen BMC (NPCM845).

The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.

Addressed comments from:
 - Krzysztof Kozlowski : https://lkml.org/lkml/2022/2/21/129
 - Wolfram Sang : https://lore.kernel.org/lkml/Yh536s%2F7bm6Xt6o3@ninjato/
 - Rob Herring : https://lkml.org/lkml/2022/2/20/425
 - Rob Herring : https://lkml.org/lkml/2022/2/22/945
 - Krzysztof Kozlowski : https://www.spinics.net/lists/linux-i2c/
                         msg55903.html
 - Jonathan Neuschäfer : https://lkml.org/lkml/2022/2/21/500
 - Krzysztof Kozlowski : https://lkml.org/lkml/2022/2/20/49

Changes since version 2:
 - Keep old code as fallback, if getting nuvoton,sys-mgr property fails.
 - Fix the error reported by running 'make DT_CHECKER_FLAGS=-m 
   dt_binding_check'.
 - Make nuvoton,sys-mgr required for nuvoton,npcm845-i2c.
 - Correct the patch's subject about changing the way of getting GCR
   regmap and add the description about keeping old code as fallback
   if getting nuvoton,sys-mgr property fails.
 - Correct the patch title and description about removing the unused 
   variable clk_regmap.
 - Use the data field directly instead of the macros since macros are
   not constants anymore in this patch.
 
Changes since version 1:
 - Add nuvoton,sys-mgr property in NPCM devicetree.
 - Describe the commit message in imperative mood.
 - Modify the description in i2c binding document to cover NPCM series.
 - Add new property in i2c binding document.
 - Create a new patch for client address calculation.
 - Create a new patch for updating gcr property name.
 - Create a new patch for removing unused clock node.
 - Explain EOB in the commit description.
 - Create a new patch for correcting NPCM register access width.
 - Remove some comment since the corresponding logic no longer exists.
 - Remove fixes tag while the patch adds an additional feature.
 - Use devicetree data field to support NPCM845.

Tali Perry (7):
  i2c: npcm: Fix client address calculation
  i2c: npcm: Change the way of getting GCR regmap
  i2c: npcm: Remove unused variable clk_regmap
  i2c: npcm: Fix timeout calculation
  i2c: npcm: Add tx complete counter
  i2c: npcm: Handle spurious interrupts
  i2c: npcm: Remove own slave addresses 2:10

Tyrone Ting (4):
  arm: dts: add new property for NPCM i2c module
  dt-bindings: i2c: npcm: support NPCM845
  i2c: npcm: Correct register access width
  i2c: npcm: Support NPCM845

 .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml     |  26 +-
 arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi |  16 +
 drivers/i2c/busses/Kconfig                    |   8 +-
 drivers/i2c/busses/Makefile                   |   2 +-
 drivers/i2c/busses/i2c-npcm7xx.c              | 291 +++++++++++-------
 5 files changed, 221 insertions(+), 122 deletions(-)

-- 
2.17.1


             reply	other threads:[~2022-03-03  8:31 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03  8:31 Tyrone Ting [this message]
2022-03-03  8:31 ` [PATCH v3 01/11] arm: dts: add new property for NPCM i2c module Tyrone Ting
2022-03-18 20:28   ` Wolfram Sang
2022-03-20  9:34     ` Tyrone Ting
2022-03-20  9:42       ` Wolfram Sang
2022-03-03  8:31 ` [PATCH v3 02/11] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-03-03 10:37   ` Krzysztof Kozlowski
2022-03-04 13:30     ` Tyrone Ting
2022-03-03  8:31 ` [PATCH v3 03/11] i2c: npcm: Fix client address calculation Tyrone Ting
2022-03-03 10:30   ` Andy Shevchenko
2022-03-04 13:39     ` Tyrone Ting
2022-03-03  8:31 ` [PATCH v3 04/11] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting
2022-03-03 10:38   ` Krzysztof Kozlowski
2022-03-04 13:32     ` Tyrone Ting
2022-03-03  8:31 ` [PATCH v3 05/11] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting
2022-03-03  8:31 ` [PATCH v3 06/11] i2c: npcm: Fix timeout calculation Tyrone Ting
2022-03-03  8:31 ` [PATCH v3 07/11] i2c: npcm: Add tx complete counter Tyrone Ting
2022-03-03  8:31 ` [PATCH v3 08/11] i2c: npcm: Correct register access width Tyrone Ting
2022-03-03 10:33   ` Andy Shevchenko
2022-03-03 12:54     ` Tali Perry
2022-03-03 14:15       ` Andy Shevchenko
2022-03-04 20:42         ` Jonathan Neuschäfer
2022-03-22 17:18           ` Avi Fishman
2022-03-22 17:51             ` Jonathan Neuschäfer
2022-03-03  8:31 ` [PATCH v3 09/11] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-03-03 10:36   ` Andy Shevchenko
2022-03-03 12:48     ` Tali Perry
2022-03-03 14:13       ` Andy Shevchenko
2022-04-04 17:03         ` Avi Fishman
2022-04-05  7:13           ` Andy Shevchenko
2022-04-10  7:33             ` Avi Fishman
2022-03-03  8:31 ` [PATCH v3 10/11] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-03-03  8:31 ` [PATCH v3 11/11] i2c: npcm: Support NPCM845 Tyrone Ting
2022-03-03 10:43   ` Andy Shevchenko
2022-03-03 12:35     ` Tali Perry
2022-03-03 14:10       ` Andy Shevchenko
     [not found]         ` <CAP6Zq1iy0yNMemqDjrLu1F0rrRSDFhZ+SqdoOa9FyJDNL0ENXA@mail.gmail.com>
2022-03-07  9:43           ` Andy Shevchenko
2022-03-03 10:26 ` [PATCH v3 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Andy Shevchenko
2022-03-03 13:03   ` Tali Perry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303083141.8742-1-warp5tw@gmail.com \
    --to=warp5tw@gmail.com \
    --cc=Avi.Fishman@nuvoton.com \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=avifishman70@gmail.com \
    --cc=bence98@sch.bme.hu \
    --cc=benjaminfair@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jie.deng@intel.com \
    --cc=kfting@nuvoton.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=olof@lixom.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=sven@svenpeter.dev \
    --cc=tali.perry1@gmail.com \
    --cc=tali.perry@nuvoton.com \
    --cc=tmaimon77@gmail.com \
    --cc=tomer.maimon@nuvoton.com \
    --cc=venture@google.com \
    --cc=wsa@kernel.org \
    --cc=yangyicong@hisilicon.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).