* [PATCH] dt-bindings: regulator: Convert TPS62360 binding to json-schema
@ 2022-03-03 12:00 Georgi Vlaev
2022-03-03 17:47 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Georgi Vlaev @ 2022-03-03 12:00 UTC (permalink / raw)
To: devicetree
Cc: robh+dt, lgirdwood, broonie, ldewangan, nm, vigneshr,
Georgi Vlaev
Convert the TPS62360 regulator binding to DT schema format
using json-schema.
Signed-off-by: Georgi Vlaev <g-vlaev@ti.com>
---
.../bindings/regulator/ti,tps62360.yaml | 99 +++++++++++++++++++
.../bindings/regulator/tps62360-regulator.txt | 44 ---------
2 files changed, 99 insertions(+), 44 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
new file mode 100644
index 000000000000..73674ef4d903
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps62360.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments TPS6236x Voltage Regulators
+
+maintainers:
+ - Laxman Dewangan <ldewangan@nvidia.com>
+
+description: |
+ The TPS6236x are a family of step down dc-dc converter with
+ an input voltage range of 2.5V to 5.5V. The devices provide
+ up to 3A peak load current, and an output voltage range of
+ 0.77V to 1.4V (TPS62360/62) and 0.5V to 1.77V (TPS62361B/63).
+
+ Datasheet is available at:
+ https://www.ti.com/lit/gpn/tps62360
+
+allOf:
+ - $ref: "regulator.yaml#"
+
+properties:
+ compatible:
+ enum:
+ - ti,tps62360
+ - ti,tps62361
+ - ti,tps62362
+ - ti,tps62363
+
+ reg:
+ maxItems: 1
+
+ ti,vsel0-gpio:
+ description: |
+ GPIO for controlling VSEL0 line. If this property
+ is missing, then assume that there is no GPIO for
+ VSEL0 control.
+ maxItems: 1
+
+ ti,vsel1-gpio:
+ description: |
+ GPIO for controlling VSEL1 line. If this property
+ is missing, then assume that there is no GPIO for
+ VSEL1 control.
+ maxItems: 1
+
+ ti,enable-vout-discharge:
+ description: Enable output discharge.
+ type: boolean
+
+ ti,enable-pull-down:
+ description: Enable pull down.
+ type: boolean
+
+ ti,vsel0-state-high:
+ description: |
+ Initial state of VSEL0 input is high. If this property
+ is missing, then assume the state as low.
+ type: boolean
+
+ ti,vsel1-state-high:
+ description: |
+ Initial state of VSEL1 input is high. If this property
+ is missing, then assume the state as low.
+ type: boolean
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ regulator@60 {
+ compatible = "ti,tps62361";
+ reg = <0x60>;
+ regulator-name = "tps62361-vout";
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ ti,vsel0-gpio = <&gpio1 16 GPIO_ACTIVE_HIGH>;
+ ti,vsel1-gpio = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+ ti,vsel0-state-high;
+ ti,vsel1-state-high;
+ ti,enable-pull-down;
+ ti,enable-force-pwm;
+ ti,enable-vout-discharge;
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt b/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
deleted file mode 100644
index 1b20c3dbcdb8..000000000000
--- a/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
+++ /dev/null
@@ -1,44 +0,0 @@
-TPS62360 Voltage regulators
-
-Required properties:
-- compatible: Must be one of the following.
- "ti,tps62360"
- "ti,tps62361",
- "ti,tps62362",
- "ti,tps62363",
-- reg: I2C slave address
-
-Optional properties:
-- ti,enable-vout-discharge: Enable output discharge. This is boolean value.
-- ti,enable-pull-down: Enable pull down. This is boolean value.
-- ti,vsel0-gpio: GPIO for controlling VSEL0 line.
- If this property is missing, then assume that there is no GPIO
- for vsel0 control.
-- ti,vsel1-gpio: Gpio for controlling VSEL1 line.
- If this property is missing, then assume that there is no GPIO
- for vsel1 control.
-- ti,vsel0-state-high: Initial state of vsel0 input is high.
- If this property is missing, then assume the state as low (0).
-- ti,vsel1-state-high: Initial state of vsel1 input is high.
- If this property is missing, then assume the state as low (0).
-
-Any property defined as part of the core regulator binding, defined in
-regulator.txt, can also be used.
-
-Example:
-
- abc: tps62360 {
- compatible = "ti,tps62361";
- reg = <0x60>;
- regulator-name = "tps62361-vout";
- regulator-min-microvolt = <500000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on
- ti,vsel0-gpio = <&gpio1 16 0>;
- ti,vsel1-gpio = <&gpio1 17 0>;
- ti,vsel0-state-high;
- ti,vsel1-state-high;
- ti,enable-pull-down;
- ti,enable-force-pwm;
- ti,enable-vout-discharge;
- };
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: regulator: Convert TPS62360 binding to json-schema
2022-03-03 12:00 [PATCH] dt-bindings: regulator: Convert TPS62360 binding to json-schema Georgi Vlaev
@ 2022-03-03 17:47 ` Krzysztof Kozlowski
2022-03-04 8:08 ` [PATCH v2] " Georgi Vlaev
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-03 17:47 UTC (permalink / raw)
To: Georgi Vlaev, devicetree
Cc: robh+dt, lgirdwood, broonie, ldewangan, nm, vigneshr
On 03/03/2022 13:00, Georgi Vlaev wrote:
> Convert the TPS62360 regulator binding to DT schema format
> using json-schema.
>
> Signed-off-by: Georgi Vlaev <g-vlaev@ti.com>
> ---
> .../bindings/regulator/ti,tps62360.yaml | 99 +++++++++++++++++++
> .../bindings/regulator/tps62360-regulator.txt | 44 ---------
> 2 files changed, 99 insertions(+), 44 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
>
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
> new file mode 100644
> index 000000000000..73674ef4d903
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/ti,tps62360.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TPS6236x Voltage Regulators
> +
> +maintainers:
> + - Laxman Dewangan <ldewangan@nvidia.com>
> +
> +description: |
> + The TPS6236x are a family of step down dc-dc converter with
> + an input voltage range of 2.5V to 5.5V. The devices provide
> + up to 3A peak load current, and an output voltage range of
> + 0.77V to 1.4V (TPS62360/62) and 0.5V to 1.77V (TPS62361B/63).
> +
> + Datasheet is available at:
> + https://www.ti.com/lit/gpn/tps62360
> +
> +allOf:
> + - $ref: "regulator.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tps62360
> + - ti,tps62361
> + - ti,tps62362
> + - ti,tps62363
> +
> + reg:
> + maxItems: 1
> +
> + ti,vsel0-gpio:
> + description: |
> + GPIO for controlling VSEL0 line. If this property
> + is missing, then assume that there is no GPIO for
> + VSEL0 control.
> + maxItems: 1
> +
> + ti,vsel1-gpio:
> + description: |
> + GPIO for controlling VSEL1 line. If this property
> + is missing, then assume that there is no GPIO for
> + VSEL1 control.
> + maxItems: 1
> +
> + ti,enable-vout-discharge:
> + description: Enable output discharge.
> + type: boolean
> +
> + ti,enable-pull-down:
> + description: Enable pull down.
> + type: boolean
> +
> + ti,vsel0-state-high:
> + description: |
> + Initial state of VSEL0 input is high. If this property
> + is missing, then assume the state as low.
> + type: boolean
> +
> + ti,vsel1-state-high:
> + description: |
> + Initial state of VSEL1 input is high. If this property
> + is missing, then assume the state as low.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + regulator@60 {
> + compatible = "ti,tps62361";
In-consisting indentation. Use 4 spaces for entire DT example.
Rest looks good.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] dt-bindings: regulator: Convert TPS62360 binding to json-schema
2022-03-03 17:47 ` Krzysztof Kozlowski
@ 2022-03-04 8:08 ` Georgi Vlaev
2022-03-04 8:11 ` Krzysztof Kozlowski
2022-03-07 12:37 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Georgi Vlaev @ 2022-03-04 8:08 UTC (permalink / raw)
To: krzysztof.kozlowski, devicetree
Cc: robh+dt, lgirdwood, broonie, ldewangan, nm, vigneshr,
Georgi Vlaev
Convert the TPS62360 regulator binding to DT schema format
using json-schema.
Signed-off-by: Georgi Vlaev <g-vlaev@ti.com>
---
V1 -> V2: Make the example indentation consistent.
.../bindings/regulator/ti,tps62360.yaml | 99 +++++++++++++++++++
.../bindings/regulator/tps62360-regulator.txt | 44 ---------
2 files changed, 99 insertions(+), 44 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
new file mode 100644
index 000000000000..525e9a46ce1b
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps62360.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments TPS6236x Voltage Regulators
+
+maintainers:
+ - Laxman Dewangan <ldewangan@nvidia.com>
+
+description: |
+ The TPS6236x are a family of step down dc-dc converter with
+ an input voltage range of 2.5V to 5.5V. The devices provide
+ up to 3A peak load current, and an output voltage range of
+ 0.77V to 1.4V (TPS62360/62) and 0.5V to 1.77V (TPS62361B/63).
+
+ Datasheet is available at:
+ https://www.ti.com/lit/gpn/tps62360
+
+allOf:
+ - $ref: "regulator.yaml#"
+
+properties:
+ compatible:
+ enum:
+ - ti,tps62360
+ - ti,tps62361
+ - ti,tps62362
+ - ti,tps62363
+
+ reg:
+ maxItems: 1
+
+ ti,vsel0-gpio:
+ description: |
+ GPIO for controlling VSEL0 line. If this property
+ is missing, then assume that there is no GPIO for
+ VSEL0 control.
+ maxItems: 1
+
+ ti,vsel1-gpio:
+ description: |
+ GPIO for controlling VSEL1 line. If this property
+ is missing, then assume that there is no GPIO for
+ VSEL1 control.
+ maxItems: 1
+
+ ti,enable-vout-discharge:
+ description: Enable output discharge.
+ type: boolean
+
+ ti,enable-pull-down:
+ description: Enable pull down.
+ type: boolean
+
+ ti,vsel0-state-high:
+ description: |
+ Initial state of VSEL0 input is high. If this property
+ is missing, then assume the state as low.
+ type: boolean
+
+ ti,vsel1-state-high:
+ description: |
+ Initial state of VSEL1 input is high. If this property
+ is missing, then assume the state as low.
+ type: boolean
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ regulator@60 {
+ compatible = "ti,tps62361";
+ reg = <0x60>;
+ regulator-name = "tps62361-vout";
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ ti,vsel0-gpio = <&gpio1 16 GPIO_ACTIVE_HIGH>;
+ ti,vsel1-gpio = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+ ti,vsel0-state-high;
+ ti,vsel1-state-high;
+ ti,enable-pull-down;
+ ti,enable-force-pwm;
+ ti,enable-vout-discharge;
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt b/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
deleted file mode 100644
index 1b20c3dbcdb8..000000000000
--- a/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
+++ /dev/null
@@ -1,44 +0,0 @@
-TPS62360 Voltage regulators
-
-Required properties:
-- compatible: Must be one of the following.
- "ti,tps62360"
- "ti,tps62361",
- "ti,tps62362",
- "ti,tps62363",
-- reg: I2C slave address
-
-Optional properties:
-- ti,enable-vout-discharge: Enable output discharge. This is boolean value.
-- ti,enable-pull-down: Enable pull down. This is boolean value.
-- ti,vsel0-gpio: GPIO for controlling VSEL0 line.
- If this property is missing, then assume that there is no GPIO
- for vsel0 control.
-- ti,vsel1-gpio: Gpio for controlling VSEL1 line.
- If this property is missing, then assume that there is no GPIO
- for vsel1 control.
-- ti,vsel0-state-high: Initial state of vsel0 input is high.
- If this property is missing, then assume the state as low (0).
-- ti,vsel1-state-high: Initial state of vsel1 input is high.
- If this property is missing, then assume the state as low (0).
-
-Any property defined as part of the core regulator binding, defined in
-regulator.txt, can also be used.
-
-Example:
-
- abc: tps62360 {
- compatible = "ti,tps62361";
- reg = <0x60>;
- regulator-name = "tps62361-vout";
- regulator-min-microvolt = <500000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on
- ti,vsel0-gpio = <&gpio1 16 0>;
- ti,vsel1-gpio = <&gpio1 17 0>;
- ti,vsel0-state-high;
- ti,vsel1-state-high;
- ti,enable-pull-down;
- ti,enable-force-pwm;
- ti,enable-vout-discharge;
- };
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] dt-bindings: regulator: Convert TPS62360 binding to json-schema
2022-03-04 8:08 ` [PATCH v2] " Georgi Vlaev
@ 2022-03-04 8:11 ` Krzysztof Kozlowski
2022-03-04 8:41 ` Laxman Dewangan
2022-03-07 12:37 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-04 8:11 UTC (permalink / raw)
To: Georgi Vlaev, devicetree
Cc: robh+dt, lgirdwood, broonie, ldewangan, nm, vigneshr
On 04/03/2022 09:08, Georgi Vlaev wrote:
> Convert the TPS62360 regulator binding to DT schema format
> using json-schema.
>
> Signed-off-by: Georgi Vlaev <g-vlaev@ti.com>
> ---
> V1 -> V2: Make the example indentation consistent.
>
> .../bindings/regulator/ti,tps62360.yaml | 99 +++++++++++++++++++
> .../bindings/regulator/tps62360-regulator.txt | 44 ---------
> 2 files changed, 99 insertions(+), 44 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
>
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
> new file mode 100644
> index 000000000000..525e9a46ce1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/ti,tps62360.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TPS6236x Voltage Regulators
> +
> +maintainers:
> + - Laxman Dewangan <ldewangan@nvidia.com>
It would be good if Laxman acks this, but from my side:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] dt-bindings: regulator: Convert TPS62360 binding to json-schema
2022-03-04 8:11 ` Krzysztof Kozlowski
@ 2022-03-04 8:41 ` Laxman Dewangan
0 siblings, 0 replies; 6+ messages in thread
From: Laxman Dewangan @ 2022-03-04 8:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, Georgi Vlaev, devicetree@vger.kernel.org
Cc: robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
nm@ti.com, vigneshr@ti.com
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +title: Texas Instruments TPS6236x Voltage Regulators
> +
> +maintainers:
> + - Laxman Dewangan <ldewangan@nvidia.com>
LGTM,
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
[Apologizing if mail get messed up due to outlook]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dt-bindings: regulator: Convert TPS62360 binding to json-schema
2022-03-04 8:08 ` [PATCH v2] " Georgi Vlaev
2022-03-04 8:11 ` Krzysztof Kozlowski
@ 2022-03-07 12:37 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2022-03-07 12:37 UTC (permalink / raw)
To: Georgi Vlaev
Cc: krzysztof.kozlowski, devicetree, robh+dt, lgirdwood, ldewangan,
nm, vigneshr
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Fri, Mar 04, 2022 at 10:08:11AM +0200, Georgi Vlaev wrote:
> Convert the TPS62360 regulator binding to DT schema format
> using json-schema.
Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-07 12:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-03 12:00 [PATCH] dt-bindings: regulator: Convert TPS62360 binding to json-schema Georgi Vlaev
2022-03-03 17:47 ` Krzysztof Kozlowski
2022-03-04 8:08 ` [PATCH v2] " Georgi Vlaev
2022-03-04 8:11 ` Krzysztof Kozlowski
2022-03-04 8:41 ` Laxman Dewangan
2022-03-07 12:37 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).