From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
devicetree@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>
Subject: [PATCH] ARM: dts: am33xx-l4: Add missing touchscreen clock properties
Date: Mon, 7 Mar 2022 12:14:13 +0100 [thread overview]
Message-ID: <20220307111413.8903-1-miquel.raynal@bootlin.com> (raw)
When adding support for TI magadc, the MFD driver (common to the
touchscreen and the ADC) got updated to ease the insertion of a new DT
node for the ADC, with its own compatible, clocks, etc. Commit
235a96e92c16 ("mfd: ti_am335x_tscadc: Don't search the tree for our
clock") removed one compatible specific information which was the clock
name, because the clock was looked up from scratch in the DT while this
hardware block was only fed by a single clock, already defined and
properly filled in the DT.
Problem is, this change was only validated with an am437x-based board,
where the clocks are effectively correctly defined and referenced. But
on am33xx, the ADC clock is also correctly defined but is not referenced
with a clock phandle as it out to be.
The touchscreen bindings clearly state that the clocks/clock-names
properties are mandatory, but they have been forgotten in one DTSI. This
was probably not noticed in the first place because of the clock
actually existing and the clk_get() call going through all the tree
anyway.
Add the missing clock phandles in the am33xx touchscreen description.
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Fixes: 235a96e92c16 ("mfd: ti_am335x_tscadc: Don't search the tree for our clock")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Hello Nikolaus, as I told you I don't have the relevant hardware to
verify that this actually fixes your situation but I am rather
confident. Could you please give this a try?
Thanks! Miquel
arch/arm/boot/dts/am33xx-l4.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
index c9629cb5ccd1..7da42a5b959c 100644
--- a/arch/arm/boot/dts/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/am33xx-l4.dtsi
@@ -263,6 +263,8 @@ tscadc: tscadc@0 {
compatible = "ti,am3359-tscadc";
reg = <0x0 0x1000>;
interrupts = <16>;
+ clocks = <&adc_tsc_fck>;
+ clock-names = "fck";
status = "disabled";
dmas = <&edma 53 0>, <&edma 57 0>;
dma-names = "fifo0", "fifo1";
--
2.27.0
next reply other threads:[~2022-03-07 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 11:14 Miquel Raynal [this message]
2022-03-07 19:19 ` [PATCH] ARM: dts: am33xx-l4: Add missing touchscreen clock properties H. Nikolaus Schaller
2022-03-08 9:48 ` Miquel Raynal
2022-03-08 9:54 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307111413.8903-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=lee.jones@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox