From: Alifer Moraes <alifer.m@variscite.com>
To: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
eran.m@variscite.com, festevam@gmail.com, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-input@vger.kernel.org, pierluigi.p@variscite.com,
robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
u.kleine-koenig@pengutronix.de, mcontenti <marco.c@variscite.com>,
Alifer Moraes <alifer.m@variscite.com>
Subject: [PATCH] input: keyboard: snvs_pwrkey: Add key-release-only
Date: Mon, 7 Mar 2022 11:24:42 -0300 [thread overview]
Message-ID: <20220307142442.28206-1-alifer.m@variscite.com> (raw)
From: Eran Matityahu <eran.m@variscite.com>
On imx6qdl the interrupt only triggers on the release of the key.
Normally, the driver is looking for a change in the state of the key,
but since the interrupt triggers on release the key value is always 0,
so there was no event.
Add "key-release-only" boolean dts property to address this issue,
and create both key press and key release events when the key
is actually released.
Signed-off-by: Eran Matityahu <eran.m@variscite.com>
Signed-off-by: mcontenti <marco.c@variscite.com>
Signed-off-by: Alifer Moraes <alifer.m@variscite.com>
---
arch/arm/boot/dts/imx6qdl.dtsi | 1 +
drivers/input/keyboard/snvs_pwrkey.c | 21 ++++++++++++++++++++-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index d27beb47f9a3..9811e6bfd8e5 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -845,6 +845,7 @@ snvs_pwrkey: snvs-powerkey {
regmap = <&snvs>;
interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
linux,keycode = <KEY_POWER>;
+ key-release-only;
wakeup-source;
status = "disabled";
};
diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
index 65286762b02a..b558e6f898fa 100644
--- a/drivers/input/keyboard/snvs_pwrkey.c
+++ b/drivers/input/keyboard/snvs_pwrkey.c
@@ -66,6 +66,22 @@ static void imx_imx_snvs_check_for_events(struct timer_list *t)
}
}
+static void imx_imx_snvs_check_for_release_events(struct timer_list *t)
+{
+ struct pwrkey_drv_data *pdata = from_timer(pdata, t, check_timer);
+ struct input_dev *input = pdata->input;
+ u32 state;
+
+ /* interrupt only reports release of key so do not wait for state change */
+ state = 1;
+ input_event(input, EV_KEY, pdata->keycode, state);
+ input_sync(input);
+
+ state = 0;
+ input_event(input, EV_KEY, pdata->keycode, state);
+ input_sync(input);
+}
+
static irqreturn_t imx_snvs_pwrkey_interrupt(int irq, void *dev_id)
{
struct platform_device *pdev = dev_id;
@@ -177,7 +193,10 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
/* clear the unexpected interrupt before driver ready */
regmap_write(pdata->snvs, SNVS_LPSR_REG, SNVS_LPSR_SPO);
- timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_events, 0);
+ if (of_property_read_bool(np, "key-release-only"))
+ timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_release_events, 0);
+ else
+ timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_events, 0);
input = devm_input_allocate_device(&pdev->dev);
if (!input) {
--
2.25.1
next reply other threads:[~2022-03-07 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 14:24 Alifer Moraes [this message]
2022-03-08 1:16 ` [PATCH] input: keyboard: snvs_pwrkey: Add key-release-only Jacky Bai
2022-03-08 1:43 ` Jacky Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307142442.28206-1-alifer.m@variscite.com \
--to=alifer.m@variscite.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eran.m@variscite.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.c@variscite.com \
--cc=pierluigi.p@variscite.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).