From: Robert Foss <robert.foss@linaro.org>
To: airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org,
matthias.bgg@gmail.com, robert.foss@linaro.org,
laurent.pinchart@ideasonboard.com, xji@analogixsemi.com,
hsinyi@chromium.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>,
arnd@arndb.de
Subject: [PATCH v2 0/2] Revert vendor property from anx7625 bindings
Date: Tue, 8 Mar 2022 10:49:09 +0100 [thread overview]
Message-ID: <20220308094911.2680291-1-robert.foss@linaro.org> (raw)
An issue[1] related to how the V4L2_FWNODE_BUS_TYPE_PARALLEL flag is mis-used
was found in recent addition to the anx7625 driver.
As used currently CPI (camera parallel interface) and DPI
(display parallel interface) would share the
V4L2_FWNODE_BUS_TYPE_PARALLEL enum. I think that would be perfectly
functional, but it is not what V4L2_FWNODE_BUS_TYPE_PARALLEL is
documented to represent. As far as I can see it's only intended to
represent CPI.
Instead of having V4L2_FWNODE_BUS_TYPE_PARALLEL represent two
standards, I think they should be split. And possibly
V4L2_FWNODE_BUS_TYPE_PARALLEL should be renamed for CPI, but that is a
separate story. This would provide for the neatest and most legible
solution. If this solution is implemented, this range would be
incorrect. Additionally the snippet reverted in 2/2 of this series
would no longer be valid.
As it stands V4L2_FWNODE_BUS_TYPE_PARALLEL was used to represent DPI
due to not being caught in the review process.
In order to not introduce this issue into the ABI, let's revert the changes
to the anx7625 dt-binding related to this.
[1] https://lore.kernel.org/all/YiTruiCIkyxs3jTC@pendragon.ideasonboard.com/
Robert Foss (2):
dt-bindings: drm/bridge: anx7625: Revert DPI support
Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI
endpoint"
.../display/bridge/analogix,anx7625.yaml | 19 +------------------
.../dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 --
2 files changed, 1 insertion(+), 20 deletions(-)
--
2.32.0
next reply other threads:[~2022-03-08 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 9:49 Robert Foss [this message]
2022-03-08 9:49 ` [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: Revert DPI support Robert Foss
2022-03-08 13:53 ` Rob Herring
2022-03-08 9:49 ` [PATCH v2 2/2] Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint" Robert Foss
2022-03-08 14:17 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308094911.2680291-1-robert.foss@linaro.org \
--to=robert.foss@linaro.org \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).