[PATCH] ARM: dts: dra7: Fix suspend warning for vpe powerdomain

[PATCH] ARM: dts: dra7: Fix suspend warning for vpe powerdomain

[Tony Lindgren]

We currently are getting the following warning after a system suspend:

Powerdomain (vpe_pwrdm) didn't enter target state 0

Looks like this is because the STANDBYMODE bit for SMART_IDLE should
not be used. The TRM "Table 12-348. VPE_SYSCONFIG" says that the value
for SMART_IDLE is "0x2: Same behavior as bit-field value of 0x1". But
if the SMART_IDLE value is used, PM_VPE_PWRSTST LASTPOWERSTATEENTERED
bits always show value of 3.

Let's fix the issue by dropping SMART_IDLE for vpe. And let's also add
the missing the powerdomain for vpe.

Fixes: 1a2095160594 ("ARM: dts: dra7: Add ti-sysc node for VPE")
Cc: Benoit Parrot <bparrot@ti.com>
Reported-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/dra7-l4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
--- a/arch/arm/boot/dts/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/dra7-l4.dtsi
@@ -4189,11 +4189,11 @@ target-module@1d0010 {			/* 0x489d0000, ap 27 30.0 */
 			reg = <0x1d0010 0x4>;
 			reg-names = "sysc";
 			ti,sysc-midle = <SYSC_IDLE_FORCE>,
-					<SYSC_IDLE_NO>,
-					<SYSC_IDLE_SMART>;
+					<SYSC_IDLE_NO>;
 			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
 					<SYSC_IDLE_NO>,
 					<SYSC_IDLE_SMART>;
+			power-domains = <&prm_vpe>;
 			clocks = <&vpe_clkctrl DRA7_VPE_VPE_CLKCTRL 0>;
 			clock-names = "fck";
 			#address-cells = <1>;
-- 
2.35.1

Re: [PATCH] ARM: dts: dra7: Fix suspend warning for vpe powerdomain

[Kevin Hilman]

Tony Lindgren <tony@atomide.com> writes:

> We currently are getting the following warning after a system suspend:
>
> Powerdomain (vpe_pwrdm) didn't enter target state 0
>
> Looks like this is because the STANDBYMODE bit for SMART_IDLE should
> not be used. The TRM "Table 12-348. VPE_SYSCONFIG" says that the value
> for SMART_IDLE is "0x2: Same behavior as bit-field value of 0x1". But
> if the SMART_IDLE value is used, PM_VPE_PWRSTST LASTPOWERSTATEENTERED
> bits always show value of 3.
>
> Let's fix the issue by dropping SMART_IDLE for vpe. And let's also add
> the missing the powerdomain for vpe.
>
> Fixes: 1a2095160594 ("ARM: dts: dra7: Add ti-sysc node for VPE")
> Cc: Benoit Parrot <bparrot@ti.com>
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Thanks for the fix.  Verified on beagle-x5.

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>