From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE5A7C433FE for ; Tue, 15 Mar 2022 08:02:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345683AbiCOIDW (ORCPT ); Tue, 15 Mar 2022 04:03:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345671AbiCOIDW (ORCPT ); Tue, 15 Mar 2022 04:03:22 -0400 Received: from smtp-out.xnet.cz (smtp-out.xnet.cz [178.217.244.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CD84BBBE; Tue, 15 Mar 2022 01:02:10 -0700 (PDT) Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id AF527183A2; Tue, 15 Mar 2022 09:02:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=true.cz; s=xnet; t=1647331329; bh=Owgjpt9llFly8+dfQ/MyEmdugi3jXELC/2QOvA1Yplw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To; b=RksBD10DTBfymcyc0tskKWTanzG6CEDK8a+QhF0EhUkiSh1bldkhga8ViEOgnnthc Nzs9BB4sVW25Df5/L+nrQkSAZmyvD4oum9Ej+IRCYrePc/YELButYksL9ODTppiKaK 8XvCrce2WNdoX7QtlftDvNI5rvlq2FWV8G7QIlYg= Received: by meh.true.cz (OpenSMTPD) with SMTP id 36d5bdad; Tue, 15 Mar 2022 09:01:44 +0100 (CET) Date: Tue, 15 Mar 2022 09:02:06 +0100 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Corentin Labbe Cc: Greg Kroah-Hartman , Maxime Ripard , Bastien =?utf-8?Q?Roucari=C3=A8s?= , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , stable@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Message-ID: <20220315080206.GA12404@meh.true.cz> Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= References: <20220308125531.27305-1-ynezz@true.cz> <20220315072846.GA9129@meh.true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-PGP-Key: https://gist.githubusercontent.com/ynezz/477f6d7a1623a591b0806699f9fc8a27/raw/a0878b8ed17e56f36ebf9e06a6b888a2cd66281b/pgp-key.pub Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Corentin Labbe [2022-03-15 08:37:06]: Hi, > If your patch is applied, older revisions will stop working, right ? correct, in the same way new revisions stopped working when that wrong fix was applied. > What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ? >From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY. Cheers, Petr