* [PATCH -next] dt-bindings:i kbuild: Make DT_SCHEMA_LINT a recursive variable
@ 2022-03-15 20:20 Nathan Chancellor
2022-03-23 18:48 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2022-03-15 20:20 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, patches, Nathan Chancellor
A recent change added a warning when yamllint is not installed, as it is
needed for 'make dt_binding_check'. However, it also changed
DT_SCHEMA_LINT to be a simple make variable, which is evaluated when a
Makefile is evaluated. This causes a warning when running 'make clean',
as Documentation/devicetree/bindings/Makefile has a "clean-files"
variable:
$ make -s clean
which: no yamllint in (...)
warning: python package 'yamllint' not installed, skipping
Make DT_SCHEMA_LINT a recursive variable so it is evaluated only when it
is used. The warning still triggers when 'make dt_binding_check' is run.
Fixes: b3e664a7f449 ("dt-bindings: kbuild: Print a warning if yamllint is not found")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
Documentation/devicetree/bindings/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index e594e5898be0..c9953f86b19d 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -3,7 +3,7 @@ DT_DOC_CHECKER ?= dt-doc-validate
DT_EXTRACT_EX ?= dt-extract-example
DT_MK_SCHEMA ?= dt-mk-schema
-DT_SCHEMA_LINT := $(shell which yamllint || \
+DT_SCHEMA_LINT = $(shell which yamllint || \
echo "warning: python package 'yamllint' not installed, skipping" >&2)
DT_SCHEMA_MIN_VERSION = 2022.3
base-commit: 593adaa6459903728cb59392239f2c615b8dadbb
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] dt-bindings:i kbuild: Make DT_SCHEMA_LINT a recursive variable
2022-03-15 20:20 [PATCH -next] dt-bindings:i kbuild: Make DT_SCHEMA_LINT a recursive variable Nathan Chancellor
@ 2022-03-23 18:48 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-03-23 18:48 UTC (permalink / raw)
To: Nathan Chancellor
Cc: patches, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-kernel
On Tue, 15 Mar 2022 13:20:32 -0700, Nathan Chancellor wrote:
> A recent change added a warning when yamllint is not installed, as it is
> needed for 'make dt_binding_check'. However, it also changed
> DT_SCHEMA_LINT to be a simple make variable, which is evaluated when a
> Makefile is evaluated. This causes a warning when running 'make clean',
> as Documentation/devicetree/bindings/Makefile has a "clean-files"
> variable:
>
> $ make -s clean
> which: no yamllint in (...)
> warning: python package 'yamllint' not installed, skipping
>
> Make DT_SCHEMA_LINT a recursive variable so it is evaluated only when it
> is used. The warning still triggers when 'make dt_binding_check' is run.
>
> Fixes: b3e664a7f449 ("dt-bindings: kbuild: Print a warning if yamllint is not found")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> Documentation/devicetree/bindings/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-23 18:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-15 20:20 [PATCH -next] dt-bindings:i kbuild: Make DT_SCHEMA_LINT a recursive variable Nathan Chancellor
2022-03-23 18:48 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).