devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	devicetree@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH 4/5 v2] dt-bindings: gnss: Add two more chips
Date: Thu, 17 Mar 2022 23:58:43 +0100	[thread overview]
Message-ID: <20220317225844.1262643-4-linus.walleij@linaro.org> (raw)
In-Reply-To: <20220317225844.1262643-1-linus.walleij@linaro.org>

The CSR GSD4t is a CSR product using the SiRFstarIV core, and
the CSR CSRG05TA03-ICJE-R is a CSR product using the SiRFstarV
core.

These chips have a SRESETN line that can be pulled low to hard
reset the chip and in some designs this is connected to a GPIO,
so add this as an optional property.

Update the example with a reset line so users see that it need
to be tagged as active low.

Cc: devicetree@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Add maxItems: 1 to the reset-gpios
---
 Documentation/devicetree/bindings/gnss/sirfstar.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.yaml b/Documentation/devicetree/bindings/gnss/sirfstar.yaml
index 9f80add3e61b..f3d8902dca04 100644
--- a/Documentation/devicetree/bindings/gnss/sirfstar.yaml
+++ b/Documentation/devicetree/bindings/gnss/sirfstar.yaml
@@ -25,6 +25,8 @@ description:
 properties:
   compatible:
     enum:
+      - csr,gsd4t
+      - csr,csrg05ta03-icje-r
       - fastrax,uc430
       - linx,r4
       - wi2wi,w2sg0004
@@ -39,6 +41,11 @@ properties:
     description:
       Main voltage regulator, pin names such as 3V3_IN, VCC, VDD.
 
+  reset-gpios:
+    maxItems: 1
+    description: An optional active low reset line, should be flagged with
+      GPIO_ACTIVE_LOW.
+
   timepulse-gpios:
     description: Comes with pin names such as 1PPS or TM
 
@@ -64,6 +71,7 @@ examples:
         gnss {
             compatible = "wi2wi,w2sg0084i";
             vcc-supply = <&gnss_vcc_reg>;
+            reset-gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
             sirf,onoff-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
             sirf,wakeup-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>;
             current-speed = <38400>;
-- 
2.35.1


  parent reply	other threads:[~2022-03-17 23:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 22:58 [PATCH 1/5 v2] dt-bindings: gnss: Rewrite common bindings in YAML Linus Walleij
2022-03-17 22:58 ` [PATCH 2/5 v2] dt-bindings: gnss: Modify u-blox to use common bindings Linus Walleij
2022-03-18  9:13   ` Krzysztof Kozlowski
2022-03-20 18:54   ` Rob Herring
2022-03-17 22:58 ` [PATCH 3/5 v2] dt-bindings: gnss: Rewrite sirfstar binding in YAML Linus Walleij
2022-03-18  9:29   ` Krzysztof Kozlowski
2022-03-20 18:58     ` Rob Herring
2022-03-22  0:01       ` Linus Walleij
2022-03-17 22:58 ` Linus Walleij [this message]
2022-03-18  9:29   ` [PATCH 4/5 v2] dt-bindings: gnss: Add two more chips Krzysztof Kozlowski
2022-03-21 18:59   ` Rob Herring
2022-03-17 22:58 ` [PATCH 5/5 v2] dt-bindings: gnss: Rewrite Mediatek bindings in YAML Linus Walleij
2022-03-18  9:33   ` Krzysztof Kozlowski
2022-03-20 18:53 ` [PATCH 1/5 v2] dt-bindings: gnss: Rewrite common " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317225844.1262643-4-linus.walleij@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).