From: Guenter Roeck <linux@roeck-us.net>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] platform/chrome: cros_kbd_led_backlight: sort headers alphabetically
Date: Fri, 18 Mar 2022 10:09:12 -0700 [thread overview]
Message-ID: <20220318170912.GA687608@roeck-us.net> (raw)
In-Reply-To: <20220314090835.3822093-2-tzungbi@kernel.org>
On Mon, Mar 14, 2022 at 05:08:31PM +0800, Tzung-Bi Shih wrote:
Nit: There should be some text here describing the rationale.
With that added,
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> ---
> Changes from v1:
> - Update email address accordingly.
>
> drivers/platform/chrome/cros_kbd_led_backlight.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c
> index aa409f0201fb..f9587a562bb7 100644
> --- a/drivers/platform/chrome/cros_kbd_led_backlight.c
> +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
> @@ -4,12 +4,12 @@
> // Copyright (C) 2012 Google, Inc.
>
> #include <linux/acpi.h>
> -#include <linux/leds.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> -#include <linux/module.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> +#include <linux/leds.h>
> +#include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>
next prev parent reply other threads:[~2022-03-18 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:08 [PATCH v2 0/5] platform/chrome: cros_kbd_led_backlight: add EC PWM backend Tzung-Bi Shih
2022-03-14 9:08 ` [PATCH v2 1/5] platform/chrome: cros_kbd_led_backlight: sort headers alphabetically Tzung-Bi Shih
2022-03-18 17:09 ` Guenter Roeck [this message]
2022-03-14 9:08 ` [PATCH v2 2/5] platform/chrome: cros_kbd_led_backlight: separate ACPI backend Tzung-Bi Shih
2022-03-14 9:08 ` [PATCH v2 3/5] dt-bindings: add google,cros-kbd-led-backlight Tzung-Bi Shih
2022-03-14 9:08 ` [PATCH v2 4/5] platform/chrome: cros_kbd_led_backlight: support OF match Tzung-Bi Shih
2022-03-18 17:04 ` Guenter Roeck
2022-03-14 9:08 ` [PATCH v2 5/5] platform/chrome: cros_kbd_led_backlight: support EC PWM backend Tzung-Bi Shih
2022-03-18 17:07 ` Guenter Roeck
2022-03-21 7:18 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318170912.GA687608@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).