From: Stephen Boyd <sboyd@kernel.org>
To: Marek Vasut <marex@denx.de>, linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/3] clk: Make __clk_hw_register_fixed_factor non-static
Date: Mon, 21 Mar 2022 12:26:49 -0700 [thread overview]
Message-ID: <20220321192650.E4409C340E8@smtp.kernel.org> (raw)
In-Reply-To: <5f97232b-579f-bccf-c603-c263aea143b6@denx.de>
Quoting Marek Vasut (2022-03-20 06:23:14)
> On 3/18/22 22:03, Stephen Boyd wrote:
> > Quoting Marek Vasut (2022-02-25 20:07:22)
> >> Access to the full parameters of __clk_hw_register_fixed_factor()
> >> is useful in case a driver is registering fixed clock with only
> >> single parent, in which case the driver should set parent_name to
> >> NULL and parent_index to 0, and access to this function permits it
> >> to do just that.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Michael Turquette <mturquette@baylibre.com>
> >> Cc: Rob Herring <robh+dt@kernel.org>
> >> Cc: Stephen Boyd <sboyd@kernel.org>
> >> Cc: devicetree@vger.kernel.org
> >> To: linux-clk@vger.kernel.org
> >> ---
> >> V2: - New patch
> >> V3: - No change
> >
> > This isn't exported. Given that we don't typically export an internal
> > function (hence the double underscore) I'm going to change this to be a
> > new function. See the attached patch.
>
> I can confirm the change works and looks OK.
>
> Do you want me to send a V4 or will you squash it into these patches
> yourself when applying?
No need I fixed it up and pushed it out.
next prev parent reply other threads:[~2022-03-21 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 4:07 [PATCH v3 1/3] dt-bindings: clk: rs9: Add Renesas 9-series I2C PCIe clock generator Marek Vasut
2022-02-26 4:07 ` [PATCH v3 2/3] clk: Make __clk_hw_register_fixed_factor non-static Marek Vasut
2022-03-15 23:58 ` Stephen Boyd
2022-03-18 21:03 ` Stephen Boyd
2022-03-20 13:23 ` Marek Vasut
2022-03-21 19:26 ` Stephen Boyd [this message]
2022-03-21 19:43 ` Marek Vasut
2022-02-26 4:07 ` [PATCH v3 3/3] clk: rs9: Add Renesas 9-series PCIe clock generator driver Marek Vasut
2022-03-12 10:26 ` Marek Vasut
2022-03-15 23:58 ` Stephen Boyd
2022-03-04 23:11 ` [PATCH v3 1/3] dt-bindings: clk: rs9: Add Renesas 9-series I2C PCIe clock generator Rob Herring
2022-03-15 23:58 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321192650.E4409C340E8@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).