From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
Oliver Hartkopp <socketcan@hartkopp.net>,
Wolfgang Grandegger <wg@grandegger.com>,
David Miller <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
mark.rutland@arm.com, Carsten Emde <c.emde@osadl.org>,
armbru@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Marin Jerabek <martin.jerabek01@gmail.com>,
Ondrej Ille <ondrej.ille@gmail.com>,
Jiri Novak <jnovak@fel.cvut.cz>,
Jaroslav Beran <jara.beran@gmail.com>,
Petr Porazil <porazil@pikron.com>, Pavel Machek <pavel@ucw.cz>,
Drew Fustini <pdp7pdp7@gmail.com>
Subject: Re: [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation
Date: Tue, 22 Mar 2022 08:46:22 +0100 [thread overview]
Message-ID: <20220322074622.5gkjhs25epurecvx@pengutronix.de> (raw)
In-Reply-To: <cover.1647904780.git.pisa@cmp.felk.cvut.cz>
[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]
On 22.03.2022 00:32:27, Pavel Pisa wrote:
> This driver adds support for the CTU CAN FD open-source IP core.
> More documentation and core sources at project page
> (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core).
> The core integration to Xilinx Zynq system as platform driver
> is available (https://gitlab.fel.cvut.cz/canbus/zynq/zynq-can-sja1000-top).
> Implementation on Intel FPGA based PCI Express board is available
> from project (https://gitlab.fel.cvut.cz/canbus/pcie-ctucanfd).
> The CTU CAN FD core emulation send for review for QEMU mainline.
> Development repository for QEMU emulation - ctu-canfd branch of
> https://gitlab.fel.cvut.cz/canbus/qemu-canbus
>
> More about CAN bus related projects used and developed at CTU FEE
> on the guidepost page http://canbus.pages.fel.cvut.cz/ .
The driver looks much better now. Good work. Please have a look at the
TX path of the mcp251xfd driver, especially the tx_stop_queue and
tx_wake_queue in mcp251xfd_start_xmit() and mcp251xfd_handle_tefif(). A
lockless implementation should work in your hardware, too.
BTW: The PROP_SEG/PHASE_SEG1 issue is known:
> +A curious reader will notice that the durations of the segments PROP_SEG
> +and PHASE_SEG1 are not determined separately but rather combined and
> +then, by default, the resulting TSEG1 is evenly divided between PROP_SEG
> +and PHASE_SEG1.
and the flexcan IP core in CAN-FD mode has the same problem. When
working on the bit timing parameter, I'll plan to have separate
PROP_SEG/PHASE_SEG1 min/max in the kernel, so that the bit timing
algorithm can take care of this.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-22 7:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 23:32 [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 1/7] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 2/7] dt-bindings: net: can: binding for CTU CAN FD open-source IP core Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 3/7] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 4/7] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 5/7] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support Pavel Pisa
2022-05-03 11:37 ` Geert Uytterhoeven
2022-05-03 15:07 ` Pavel Pisa
2022-05-04 6:34 ` Marc Kleine-Budde
2022-03-21 23:32 ` [PATCH v8 6/7] docs: ctucanfd: CTU CAN FD open-source IP core documentation Pavel Pisa
2022-03-21 23:32 ` [PATCH v8 7/7] MAINTAINERS: Add maintainers for CTU CAN FD IP core driver Pavel Pisa
2022-03-22 7:46 ` Marc Kleine-Budde [this message]
2022-03-22 8:18 ` [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Pavel Pisa
2022-03-22 8:33 ` Oliver Hartkopp
2022-03-22 9:22 ` Marc Kleine-Budde
2022-03-22 13:19 ` Pavel Pisa
[not found] ` <CAA7ZjpZbppBy_C+NyN4LWQF2-a-ktfjYeNELTzwsz4B-fBiTpw@mail.gmail.com>
2022-03-30 7:54 ` Marc Kleine-Budde
2022-04-06 8:20 ` Pavel Pisa
2022-04-19 15:35 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322074622.5gkjhs25epurecvx@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=armbru@redhat.com \
--cc=c.emde@osadl.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jara.beran@gmail.com \
--cc=jnovak@fel.cvut.cz \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.jerabek01@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pavel@ucw.cz \
--cc=pdp7pdp7@gmail.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=porazil@pikron.com \
--cc=robh+dt@kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).