From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Matt Ranostay <matt.ranostay@konsulko.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Andrea Merello <andrea.merello@iit.it>
Subject: Re: [v3 13/13] docs: iio: add documentation for BNO055 driver
Date: Tue, 22 Mar 2022 20:32:16 +0000 [thread overview]
Message-ID: <20220322203216.0000141f@Huawei.com> (raw)
In-Reply-To: <CAN8YU5PvqJ3_wA7JnFRFT_53KftrqzaanELj5Xjbw0d8cnQ6tA@mail.gmail.com>
On Tue, 22 Mar 2022 11:30:12 +0100
Andrea Merello <andrea.merello@gmail.com> wrote:
> [...]
>
> > > +IIO attributes for unavailable measurements (e.g. Euler angles when fusion
> > > +mode is disabled) just read zero.
> >
> > Hmm. Should probably return -EBUSY as 0 could be a valid value.
> >
>
> While it seems reasonable, that can be easily done while reading from
> sysfs, but how do we handle this when reading from buffer?
> Right now both sysfs and buffer read zero from unused chans, which it
> is at least consistent..
Can't we refuse to start the buffer if we have a channel enabled that
makes no sense in the current mode?
If seems very odd to allow capture of 'nothing'.
Jonathan
prev parent reply other threads:[~2022-03-22 20:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 16:26 [v3 00/13] Add support for Bosch BNO055 IMU Andrea Merello
2022-02-17 16:26 ` [v3 01/13] iio: add modifiers for linear acceleration Andrea Merello
2022-02-17 16:26 ` [v3 02/13] iio: document linear acceleration modifiers Andrea Merello
2022-02-19 16:08 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 03/13] iio: event_monitor: add " Andrea Merello
2022-02-17 16:27 ` [v3 04/13] iio: add modifers for pitch, yaw, roll Andrea Merello
2022-02-17 16:27 ` [v3 05/13] iio: document pitch, yaw, roll modifiers Andrea Merello
2022-02-19 16:31 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 06/13] iio: event_monitor: add pitch, yaw and " Andrea Merello
2022-02-17 16:27 ` [v3 07/13] iio: imu: add Bosch Sensortec BNO055 core driver Andrea Merello
2022-02-17 16:27 ` [v3 08/13] iio: document bno055 private sysfs attributes Andrea Merello
2022-02-19 16:50 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 09/13] iio: document "serial_number" sysfs attribute Andrea Merello
2022-02-19 16:52 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 10/13] dt-bindings: iio: imu: add documentation for Bosch BNO055 bindings Andrea Merello
2022-02-24 19:54 ` Rob Herring
2022-02-17 16:27 ` [v3 11/13] iio: imu: add BNO055 serdev driver Andrea Merello
2022-02-17 19:47 ` kernel test robot
2022-02-18 5:20 ` kernel test robot
2022-02-21 20:27 ` Andy Shevchenko
2022-03-22 10:37 ` Andrea Merello
2022-02-17 16:27 ` [v3 12/13] iio: imu: add BNO055 I2C driver Andrea Merello
2022-02-19 17:03 ` Jonathan Cameron
2022-02-21 20:32 ` Andy Shevchenko
2022-02-17 16:27 ` [v3 13/13] docs: iio: add documentation for BNO055 driver Andrea Merello
2022-02-19 17:06 ` Jonathan Cameron
2022-03-22 10:30 ` Andrea Merello
2022-03-22 20:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322203216.0000141f@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andrea.merello@gmail.com \
--cc=andrea.merello@iit.it \
--cc=andy.shevchenko@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).