* [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example
@ 2022-03-24 11:55 Dmitry Baryshkov
2022-03-24 14:17 ` Krzysztof Kozlowski
2022-03-24 20:12 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2022-03-24 11:55 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Clark, Sean Paul, Abhinav Kumar,
Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno, Rob Herring, Loic Poulain
Make dpu-qcm2290 example really follow the defined schema:
- Drop qcom,mdss compatible. It's only used for MDP5 devices.
- Change display controller name to display-controller as specified in
the yaml
Reported-by: Rob Herring <robh@kernel.org>
Cc: Loic Poulain <loic.poulain@linaro.org>
Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../devicetree/bindings/display/msm/dpu-qcm2290.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index d31483a78eab..6fb7e321f011 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -160,7 +160,7 @@ examples:
mdss: mdss@5e00000 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "qcom,qcm2290-mdss", "qcom,mdss";
+ compatible = "qcom,qcm2290-mdss";
reg = <0x05e00000 0x1000>;
reg-names = "mdss";
power-domains = <&dispcc MDSS_GDSC>;
@@ -180,7 +180,7 @@ examples:
<&apps_smmu 0x421 0x0>;
ranges;
- mdss_mdp: mdp@5e01000 {
+ mdss_mdp: display-controller@5e01000 {
compatible = "qcom,qcm2290-dpu";
reg = <0x05e01000 0x8f000>,
<0x05eb0000 0x2008>;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example
2022-03-24 11:55 [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example Dmitry Baryshkov
@ 2022-03-24 14:17 ` Krzysztof Kozlowski
2022-03-24 20:12 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-24 14:17 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark,
Sean Paul, Abhinav Kumar, Rob Herring
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno, Rob Herring, Loic Poulain
On 24/03/2022 12:55, Dmitry Baryshkov wrote:
> Make dpu-qcm2290 example really follow the defined schema:
> - Drop qcom,mdss compatible. It's only used for MDP5 devices.
> - Change display controller name to display-controller as specified in
> the yaml
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dpu-qcm2290.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> index d31483a78eab..6fb7e321f011 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> @@ -160,7 +160,7 @@ examples:
> mdss: mdss@5e00000 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "qcom,qcm2290-mdss", "qcom,mdss";
> + compatible = "qcom,qcm2290-mdss";
That's quite unfortunate choice of compatibles. I would assume qcom,mdss
is a generic fallback compatible but it is used in different way - as a
specific compatible for MDP v5. The bindings here are for a newer
device, right?
It's already in the bindings, so not much could be fixed now...
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example
2022-03-24 11:55 [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example Dmitry Baryshkov
2022-03-24 14:17 ` Krzysztof Kozlowski
@ 2022-03-24 20:12 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2022-03-24 20:12 UTC (permalink / raw)
To: Abhinav Kumar, Andy Gross, Bjorn Andersson, Dmitry Baryshkov,
Krzysztof Kozlowski, Rob Clark, Rob Herring, Sean Paul
Cc: David Airlie, Daniel Vetter, linux-arm-msm, devicetree, dri-devel,
freedreno, Rob Herring, Loic Poulain
Quoting Dmitry Baryshkov (2022-03-24 04:55:36)
> Make dpu-qcm2290 example really follow the defined schema:
> - Drop qcom,mdss compatible. It's only used for MDP5 devices.
> - Change display controller name to display-controller as specified in
> the yaml
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-24 20:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-24 11:55 [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example Dmitry Baryshkov
2022-03-24 14:17 ` Krzysztof Kozlowski
2022-03-24 20:12 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).