From: "Clément Léger" <clement.leger@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Wolfram Sang <wsa@kernel.org>, Peter Rosin <peda@axentia.se>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Len Brown <lenb@kernel.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Allan Nielsen" <allan.nielsen@microchip.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
"Clément Léger" <clement.leger@bootlin.com>
Subject: [PATCH v3 7/9] i2c: of: use fwnode_get_i2c_adapter_by_node()
Date: Fri, 25 Mar 2022 12:31:46 +0100 [thread overview]
Message-ID: <20220325113148.588163-8-clement.leger@bootlin.com> (raw)
In-Reply-To: <20220325113148.588163-1-clement.leger@bootlin.com>
Since the new fwnode based fwnode_find_i2c_adapter_by_node() function
has the same behavior than of_get_i2c_adapter_by_node(), call it to
avoid code duplication.
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
drivers/i2c/i2c-core-of.c | 30 ------------------------------
include/linux/i2c.h | 5 ++++-
2 files changed, 4 insertions(+), 31 deletions(-)
diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c
index 3ed74aa4b44b..be7d66aa0f49 100644
--- a/drivers/i2c/i2c-core-of.c
+++ b/drivers/i2c/i2c-core-of.c
@@ -113,17 +113,6 @@ void of_i2c_register_devices(struct i2c_adapter *adap)
of_node_put(bus);
}
-static int of_dev_or_parent_node_match(struct device *dev, const void *data)
-{
- if (dev->of_node == data)
- return 1;
-
- if (dev->parent)
- return dev->parent->of_node == data;
-
- return 0;
-}
-
/* must call put_device() when done with returned i2c_client device */
struct i2c_client *of_find_i2c_device_by_node(struct device_node *node)
{
@@ -142,25 +131,6 @@ struct i2c_client *of_find_i2c_device_by_node(struct device_node *node)
}
EXPORT_SYMBOL(of_find_i2c_device_by_node);
-/* must call put_device() when done with returned i2c_adapter device */
-struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node *node)
-{
- struct device *dev;
- struct i2c_adapter *adapter;
-
- dev = bus_find_device(&i2c_bus_type, NULL, node,
- of_dev_or_parent_node_match);
- if (!dev)
- return NULL;
-
- adapter = i2c_verify_adapter(dev);
- if (!adapter)
- put_device(dev);
-
- return adapter;
-}
-EXPORT_SYMBOL(of_find_i2c_adapter_by_node);
-
/* must call i2c_put_adapter() when done with returned i2c_adapter device */
struct i2c_adapter *of_get_i2c_adapter_by_node(struct device_node *node)
{
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 8dadf8c89fd9..982918fd0093 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -975,7 +975,10 @@ fwnode_find_i2c_adapter_by_node(struct fwnode_handle *fwnode);
struct i2c_client *of_find_i2c_device_by_node(struct device_node *node);
/* must call put_device() when done with returned i2c_adapter device */
-struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node *node);
+static inline struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node *node)
+{
+ return fwnode_find_i2c_adapter_by_node(of_fwnode_handle(node));
+}
/* must call i2c_put_adapter() when done with returned i2c_adapter device */
struct i2c_adapter *of_get_i2c_adapter_by_node(struct device_node *node);
--
2.34.1
next prev parent reply other threads:[~2022-03-25 11:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 11:31 [PATCH v3 0/9] introduce fwnode in the I2C subsystem Clément Léger
2022-03-25 11:31 ` [PATCH v3 1/9] of: add of_property_read_string_array_index() Clément Léger
2022-03-29 23:32 ` Rob Herring
2022-03-25 11:31 ` [PATCH v3 2/9] of: unittests: add tests for of_property_read_string_array_index() Clément Léger
2022-03-29 23:32 ` Rob Herring
2022-03-25 11:31 ` [PATCH v3 3/9] device property: add index argument to property_read_string_array() callback Clément Léger
2022-03-25 14:30 ` Andy Shevchenko
2022-03-28 14:28 ` Clément Léger
2022-04-05 13:22 ` Rafael J. Wysocki
2022-04-05 13:27 ` Clément Léger
2022-03-25 11:31 ` [PATCH v3 4/9] device property: add fwnode_property_read_string_index() Clément Léger
2022-03-25 14:33 ` Andy Shevchenko
2022-03-25 15:10 ` Clément Léger
2022-03-25 11:31 ` [PATCH v3 5/9] device property: add tests for fwnode_property_read_string_index() Clément Léger
2022-03-25 11:31 ` [PATCH v3 6/9] i2c: fwnode: add fwnode_find_i2c_adapter_by_node() Clément Léger
2022-03-25 14:35 ` Andy Shevchenko
2022-03-25 15:09 ` Clément Léger
2022-03-25 15:56 ` Andy Shevchenko
2022-03-25 16:04 ` Clément Léger
2022-03-25 16:29 ` Andy Shevchenko
2022-03-25 11:31 ` Clément Léger [this message]
2022-03-25 11:31 ` [PATCH v3 8/9] i2c: mux: pinctrl: remove CONFIG_OF dependency and use fwnode API Clément Léger
2022-03-25 14:38 ` Andy Shevchenko
2022-03-25 16:48 ` Peter Rosin
2022-03-31 9:40 ` Clément Léger
2022-03-25 11:31 ` [PATCH v3 9/9] i2c: mux: add support for fwnode Clément Léger
2022-05-14 14:47 ` [PATCH v3 0/9] introduce fwnode in the I2C subsystem Wolfram Sang
2022-05-15 21:34 ` Peter Rosin
2022-05-16 7:34 ` Clément Léger
2022-05-16 8:36 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325113148.588163-8-clement.leger@bootlin.com \
--to=clement.leger@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).