[PATCH 0/4] DT updates for dma-names ordering checks

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/4] DT updates for dma-names ordering checks
@ 2022-03-26  4:23 Kuldeep Singh
  2022-03-26  4:23 ` [PATCH 1/4] ARM: dts: spear13xx: Update SPI dma properties Kuldeep Singh
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Kuldeep Singh @ 2022-03-26  4:23 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: soc, linux-arm-kernel, devicetree, linux-kernel

This patchset attempts to fix DTs possessing dma ordering issues.
The motivation of the series is taken from a discussion done before.
Link: https://lore.kernel.org/linux-devicetree/20220323175920.93155-1-singh.kuldeep87k@gmail.com/

Just a quick summary for new visitors.
There are few DTs which require dma ordering in order to resolve below
'make dtbs_check' issues and this patchset is in direction to fix that.
dma-names:0: 'rx' was expected
dma-names:0: 'tx' was expected

Kuldeep Singh (4):
  ARM: dts: spear13xx: Update SPI dma properties
  ARM: dts: spear1340: Update serial node properties
  arm64: dts: ls1043a: Update i2c dma properties
  arm64: dts: ls1046a: Update i2c node dma properties

 arch/arm/boot/dts/spear1340.dtsi               | 6 +++---
 arch/arm/boot/dts/spear13xx.dtsi               | 6 +++---
 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 6 +++---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.25.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/4] ARM: dts: spear13xx: Update SPI dma properties
  2022-03-26  4:23 [PATCH 0/4] DT updates for dma-names ordering checks Kuldeep Singh
@ 2022-03-26  4:23 ` Kuldeep Singh
  2022-03-26  4:23 ` [PATCH 2/4] ARM: dts: spear1340: Update serial node properties Kuldeep Singh
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Kuldeep Singh @ 2022-03-26  4:23 UTC (permalink / raw)
  To: Arnd Bergmann, Viresh Kumar, Shiraz Hashim, soc, Rob Herring
  Cc: linux-arm-kernel, devicetree, linux-kernel, Viresh Kumar

Reorder dmas and dma-names property for spi controller node to make it
compliant with bindings.

Fixes: 6e8887f60f60 ("ARM: SPEAr13xx: Pass generic DW DMAC platform data from DT")
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
 arch/arm/boot/dts/spear13xx.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi
index c87b881b2c8b..913553367687 100644
--- a/arch/arm/boot/dts/spear13xx.dtsi
+++ b/arch/arm/boot/dts/spear13xx.dtsi
@@ -284,9 +284,9 @@ spi0: spi@e0100000 {
 				#size-cells = <0>;
 				interrupts = <0 31 0x4>;
 				status = "disabled";
-				dmas = <&dwdma0 4 0 0>,
-					<&dwdma0 5 0 0>;
-				dma-names = "tx", "rx";
+				dmas = <&dwdma0 5 0 0>,
+					<&dwdma0 4 0 0>;
+				dma-names = "rx", "tx";
 			};
 
 			rtc@e0580000 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/4] ARM: dts: spear1340: Update serial node properties
  2022-03-26  4:23 [PATCH 0/4] DT updates for dma-names ordering checks Kuldeep Singh
  2022-03-26  4:23 ` [PATCH 1/4] ARM: dts: spear13xx: Update SPI dma properties Kuldeep Singh
@ 2022-03-26  4:23 ` Kuldeep Singh
  2022-03-28  2:08   ` Viresh Kumar
  2022-03-26  4:23 ` [PATCH 3/4] arm64: dts: ls1043a: Update i2c dma properties Kuldeep Singh
  2022-03-26  4:23 ` [PATCH 4/4] arm64: dts: ls1046a: Update i2c node " Kuldeep Singh
  3 siblings, 1 reply; 6+ messages in thread
From: Kuldeep Singh @ 2022-03-26  4:23 UTC (permalink / raw)
  To: Arnd Bergmann, Viresh Kumar, Shiraz Hashim, soc, Rob Herring
  Cc: linux-arm-kernel, devicetree, linux-kernel

Reorder dma and dma-names property for serial node to make it compliant
with bindings.

Fixes: 6e8887f60f60 ("ARM: SPEAr13xx: Pass generic DW DMAC platform data from DT")
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
 arch/arm/boot/dts/spear1340.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi
index 827e887afbda..13e1bdb3ddbf 100644
--- a/arch/arm/boot/dts/spear1340.dtsi
+++ b/arch/arm/boot/dts/spear1340.dtsi
@@ -134,9 +134,9 @@ serial@b4100000 {
 				reg = <0xb4100000 0x1000>;
 				interrupts = <0 105 0x4>;
 				status = "disabled";
-				dmas = <&dwdma0 12 0 1>,
-					<&dwdma0 13 1 0>;
-				dma-names = "tx", "rx";
+				dmas = <&dwdma0 13 0 1>,
+					<&dwdma0 12 1 0>;
+				dma-names = "rx", "tx";
 			};
 
 			thermal@e07008c4 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/4] ARM: dts: spear1340: Update serial node properties
  2022-03-26  4:23 ` [PATCH 2/4] ARM: dts: spear1340: Update serial node properties Kuldeep Singh
@ 2022-03-28  2:08   ` Viresh Kumar
  0 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2022-03-28  2:08 UTC (permalink / raw)
  To: Kuldeep Singh
  Cc: Arnd Bergmann, Viresh Kumar, Shiraz Hashim, soc, Rob Herring,
	linux-arm-kernel, devicetree, linux-kernel

On 26-03-22, 09:53, Kuldeep Singh wrote:
> Reorder dma and dma-names property for serial node to make it compliant
> with bindings.
> 
> Fixes: 6e8887f60f60 ("ARM: SPEAr13xx: Pass generic DW DMAC platform data from DT")
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
>  arch/arm/boot/dts/spear1340.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi
> index 827e887afbda..13e1bdb3ddbf 100644
> --- a/arch/arm/boot/dts/spear1340.dtsi
> +++ b/arch/arm/boot/dts/spear1340.dtsi
> @@ -134,9 +134,9 @@ serial@b4100000 {
>  				reg = <0xb4100000 0x1000>;
>  				interrupts = <0 105 0x4>;
>  				status = "disabled";
> -				dmas = <&dwdma0 12 0 1>,
> -					<&dwdma0 13 1 0>;
> -				dma-names = "tx", "rx";
> +				dmas = <&dwdma0 13 0 1>,
> +					<&dwdma0 12 1 0>;
> +				dma-names = "rx", "tx";
>  			};
>  
>  			thermal@e07008c4 {

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/4] arm64: dts: ls1043a: Update i2c dma properties
  2022-03-26  4:23 [PATCH 0/4] DT updates for dma-names ordering checks Kuldeep Singh
  2022-03-26  4:23 ` [PATCH 1/4] ARM: dts: spear13xx: Update SPI dma properties Kuldeep Singh
  2022-03-26  4:23 ` [PATCH 2/4] ARM: dts: spear1340: Update serial node properties Kuldeep Singh
@ 2022-03-26  4:23 ` Kuldeep Singh
  2022-03-26  4:23 ` [PATCH 4/4] arm64: dts: ls1046a: Update i2c node " Kuldeep Singh
  3 siblings, 0 replies; 6+ messages in thread
From: Kuldeep Singh @ 2022-03-26  4:23 UTC (permalink / raw)
  To: Arnd Bergmann, Shawn Guo, Li Yang, Rob Herring, Mingkai Hu,
	Hou Zhiqiang, Wenbin Song, Olof Johansson
  Cc: soc, linux-arm-kernel, devicetree, linux-kernel

Reorder dmas and dma-names properties for i2c controller node to make it
compliant with bindings.

Fixes: 6d453cd22357 ("arm64: dts: add Freescale LS1043a SoC support")
CC: soc@kernel.org
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 01b01e320411..35d1939e690b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -536,9 +536,9 @@ i2c0: i2c@2180000 {
 			clock-names = "i2c";
 			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
 					    QORIQ_CLK_PLL_DIV(1)>;
-			dmas = <&edma0 1 39>,
-			       <&edma0 1 38>;
-			dma-names = "tx", "rx";
+			dmas = <&edma0 1 38>,
+			       <&edma0 1 39>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/4] arm64: dts: ls1046a: Update i2c node dma properties
  2022-03-26  4:23 [PATCH 0/4] DT updates for dma-names ordering checks Kuldeep Singh
                   ` (2 preceding siblings ...)
  2022-03-26  4:23 ` [PATCH 3/4] arm64: dts: ls1043a: Update i2c dma properties Kuldeep Singh
@ 2022-03-26  4:23 ` Kuldeep Singh
  3 siblings, 0 replies; 6+ messages in thread
From: Kuldeep Singh @ 2022-03-26  4:23 UTC (permalink / raw)
  To: Arnd Bergmann, Shawn Guo, Li Yang, Rob Herring, Gong Qianyu,
	Chenhui Zhao, Hou Zhiqiang, Mihai Bantea
  Cc: soc, linux-arm-kernel, devicetree, linux-kernel, Mingkai Hu,
	Horia Geant?

Reorder dmas and dma-names properties for i2c controller node to make it
compliant with bindings.

Fixes: 8126d88162a5 ("arm64: dts: add QorIQ LS1046A SoC support")
CC: soc@kernel.org
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 687fea6d8afa..4e7bd04d9798 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -499,9 +499,9 @@ i2c0: i2c@2180000 {
 			interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
 					    QORIQ_CLK_PLL_DIV(2)>;
-			dmas = <&edma0 1 39>,
-			       <&edma0 1 38>;
-			dma-names = "tx", "rx";
+			dmas = <&edma0 1 38>,
+			       <&edma0 1 39>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-03-28  2:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-26  4:23 [PATCH 0/4] DT updates for dma-names ordering checks Kuldeep Singh
2022-03-26  4:23 ` [PATCH 1/4] ARM: dts: spear13xx: Update SPI dma properties Kuldeep Singh
2022-03-26  4:23 ` [PATCH 2/4] ARM: dts: spear1340: Update serial node properties Kuldeep Singh
2022-03-28  2:08   ` Viresh Kumar
2022-03-26  4:23 ` [PATCH 3/4] arm64: dts: ls1043a: Update i2c dma properties Kuldeep Singh
2022-03-26  4:23 ` [PATCH 4/4] arm64: dts: ls1046a: Update i2c node " Kuldeep Singh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).