From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506B9C433EF for ; Wed, 30 Mar 2022 07:18:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242822AbiC3HT7 (ORCPT ); Wed, 30 Mar 2022 03:19:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240849AbiC3HT6 (ORCPT ); Wed, 30 Mar 2022 03:19:58 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [5.144.164.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7168318EE88; Wed, 30 Mar 2022 00:18:10 -0700 (PDT) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 772943F744; Wed, 30 Mar 2022 09:18:06 +0200 (CEST) Date: Wed, 30 Mar 2022 09:17:59 +0200 From: Marijn Suijten To: Joel Selvaraj Cc: Sumit Semwal , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Andy Gross , Bjorn Andersson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Amit Pundir Subject: Re: [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel Message-ID: <20220330071759.ftcs2fhr7ehrfsqs@SoMainline.org> Mail-Followup-To: Marijn Suijten , Joel Selvaraj , Sumit Semwal , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Andy Gross , Bjorn Andersson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Amit Pundir References: <20220330065639.245531-1-jo@jsfamily.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-03-30 12:26:39, Joel Selvaraj wrote: > Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. > Enable and link it to the panel to use it. > > Signed-off-by: Joel Selvaraj > --- > .../arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > index 798fc72578a7..3ebb0f9905d3 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > @@ -231,6 +231,7 @@ panel@0 { > #address-cells = <1>; > #size-cells = <0>; > > + backlight = <&pmi8998_wled>; > reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; > > port { > @@ -314,6 +315,18 @@ vol_up_pin_a: vol-up-active { > }; > }; > > +&pmi8998_wled { > + status = "okay"; > + qcom,current-boost-limit = <970>; > + qcom,ovp-millivolt = <29600>; > + qcom,current-limit-microamp = <20000>; > + qcom,enabled-strings = <0 1>; > + qcom,num-strings = <2>; No need to set both nowadays, the driver will even print a warning in this case: https://lore.kernel.org/linux-arm-msm/20211115203459.1634079-6-marijn.suijten@somainline.org/ Sticking with qcom,num-strings is probably the right choice here. - Marijn > + qcom,switching-freq = <600>; > + qcom,external-pfet; > + qcom,cabc; > +}; > + > &pm8998_pon { > resin { > compatible = "qcom,pm8941-resin"; > -- > 2.35.1 >