* [PATCH v3 0/2] dw9807 binding and driver compatible changes
@ 2022-03-30 7:33 Sakari Ailus
2022-03-30 7:33 ` [PATCH v3 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema Sakari Ailus
2022-03-30 7:33 ` [PATCH v3 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string Sakari Ailus
0 siblings, 2 replies; 6+ messages in thread
From: Sakari Ailus @ 2022-03-30 7:33 UTC (permalink / raw)
To: linux-media; +Cc: devicetree, robh, Krzysztof Kozlowski
Hello everyone,
These two patches convert dw9807 bindings to json-schema and add a new
compatible string to the dw9807-vcm driver in order to support existing
ACPI firmware.
since v2:
- Send the correct patches --- v2 patches were from an old branch before v1.
since v1:
- Use stronger language in a comment related to a compatible string for
old firmware.
- Remove extra newlines and quotes from bindings.
Sakari Ailus (2):
dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema
dw9807-vcm: Add "dongwoon,dw9807" compatible string
.../media/i2c/dongwoon,dw9807-vcm.txt | 9 ----
.../media/i2c/dongwoon,dw9807-vcm.yaml | 41 +++++++++++++++++++
drivers/media/i2c/dw9807-vcm.c | 2 +
3 files changed, 43 insertions(+), 9 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
--
2.30.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema
2022-03-30 7:33 [PATCH v3 0/2] dw9807 binding and driver compatible changes Sakari Ailus
@ 2022-03-30 7:33 ` Sakari Ailus
2022-03-30 7:42 ` Krzysztof Kozlowski
2022-03-30 7:33 ` [PATCH v3 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string Sakari Ailus
1 sibling, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2022-03-30 7:33 UTC (permalink / raw)
To: linux-media; +Cc: devicetree, robh, Krzysztof Kozlowski
Convert the old text based dw9807-vcm chip DT bindings to json-schema.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
.../media/i2c/dongwoon,dw9807-vcm.txt | 9 ----
.../media/i2c/dongwoon,dw9807-vcm.yaml | 41 +++++++++++++++++++
2 files changed, 41 insertions(+), 9 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
deleted file mode 100644
index c4701f1eaaf63..0000000000000
--- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
+++ /dev/null
@@ -1,9 +0,0 @@
-Dongwoon Anatech DW9807 voice coil lens driver
-
-DW9807 is a 10-bit DAC with current sink capability. It is intended for
-controlling voice coil lenses.
-
-Mandatory properties:
-
-- compatible: "dongwoon,dw9807-vcm"
-- reg: I2C slave address
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
new file mode 100644
index 0000000000000..aae246ca3fcf5
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2018, 2021 Intel Corporation
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9807-vcm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dongwoon Anatech DW9807 voice coil lens driver
+
+maintainers:
+ - Sakari Ailus <sakari.ailus@linux.intel.com>
+
+description: |
+ DW9807 is a 10-bit DAC with current sink capability. It is intended for
+ controlling voice coil lenses.
+
+properties:
+ compatible:
+ const: dongwoon,dw9807-vcm
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ lens@e {
+ compatible = "dongwoon,dw9807-vcm";
+ reg = <0x0e>;
+ };
+ };
+...
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string
2022-03-30 7:33 [PATCH v3 0/2] dw9807 binding and driver compatible changes Sakari Ailus
2022-03-30 7:33 ` [PATCH v3 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema Sakari Ailus
@ 2022-03-30 7:33 ` Sakari Ailus
2022-03-30 7:42 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2022-03-30 7:33 UTC (permalink / raw)
To: linux-media; +Cc: devicetree, robh, Krzysztof Kozlowski
There is firmware out there that uses "dongwoon,dw9807" compatible string
that never made it to upstream as-is. Add it to the driver to make it load
on such systems.
The chip also has an EEPROM part which is AT24 compatible (for reading
purposes) on a separate I²C address. Adding possible support for this in
the future is not affected by this change.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/i2c/dw9807-vcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/i2c/dw9807-vcm.c b/drivers/media/i2c/dw9807-vcm.c
index 95e06f13bc9ed..01c372925a806 100644
--- a/drivers/media/i2c/dw9807-vcm.c
+++ b/drivers/media/i2c/dw9807-vcm.c
@@ -295,6 +295,8 @@ static int __maybe_unused dw9807_vcm_resume(struct device *dev)
static const struct of_device_id dw9807_of_table[] = {
{ .compatible = "dongwoon,dw9807-vcm" },
+ /* Compatibility for older firmware, NEVER USE THIS IN FIRMWARE! */
+ { .compatible = "dongwoon,dw9807" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, dw9807_of_table);
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema
2022-03-30 7:33 ` [PATCH v3 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema Sakari Ailus
@ 2022-03-30 7:42 ` Krzysztof Kozlowski
2022-03-30 7:48 ` Sakari Ailus
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-30 7:42 UTC (permalink / raw)
To: Sakari Ailus, linux-media; +Cc: devicetree, robh
On 30/03/2022 09:33, Sakari Ailus wrote:
> Convert the old text based dw9807-vcm chip DT bindings to json-schema.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> .../media/i2c/dongwoon,dw9807-vcm.txt | 9 ----
> .../media/i2c/dongwoon,dw9807-vcm.yaml | 41 +++++++++++++++++++
> 2 files changed, 41 insertions(+), 9 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string
2022-03-30 7:33 ` [PATCH v3 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string Sakari Ailus
@ 2022-03-30 7:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-30 7:42 UTC (permalink / raw)
To: Sakari Ailus, linux-media; +Cc: devicetree, robh
On 30/03/2022 09:33, Sakari Ailus wrote:
> There is firmware out there that uses "dongwoon,dw9807" compatible string
> that never made it to upstream as-is. Add it to the driver to make it load
> on such systems.
>
> The chip also has an EEPROM part which is AT24 compatible (for reading
> purposes) on a separate I²C address. Adding possible support for this in
> the future is not affected by this change.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/media/i2c/dw9807-vcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema
2022-03-30 7:42 ` Krzysztof Kozlowski
@ 2022-03-30 7:48 ` Sakari Ailus
0 siblings, 0 replies; 6+ messages in thread
From: Sakari Ailus @ 2022-03-30 7:48 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: linux-media, devicetree, robh
On Wed, Mar 30, 2022 at 09:42:03AM +0200, Krzysztof Kozlowski wrote:
> On 30/03/2022 09:33, Sakari Ailus wrote:
> > Convert the old text based dw9807-vcm chip DT bindings to json-schema.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > .../media/i2c/dongwoon,dw9807-vcm.txt | 9 ----
> > .../media/i2c/dongwoon,dw9807-vcm.yaml | 41 +++++++++++++++++++
> > 2 files changed, 41 insertions(+), 9 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
> >
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks!
--
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-30 7:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-30 7:33 [PATCH v3 0/2] dw9807 binding and driver compatible changes Sakari Ailus
2022-03-30 7:33 ` [PATCH v3 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema Sakari Ailus
2022-03-30 7:42 ` Krzysztof Kozlowski
2022-03-30 7:48 ` Sakari Ailus
2022-03-30 7:33 ` [PATCH v3 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string Sakari Ailus
2022-03-30 7:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox