From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332FBC4321E for ; Wed, 30 Mar 2022 16:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348994AbiC3QtQ (ORCPT ); Wed, 30 Mar 2022 12:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344057AbiC3QtP (ORCPT ); Wed, 30 Mar 2022 12:49:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BFFB276F8E; Wed, 30 Mar 2022 09:47:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E6E9C617E0; Wed, 30 Mar 2022 16:47:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19633C340EE; Wed, 30 Mar 2022 16:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648658849; bh=XcUY+3+TSV7tfrriu0LhCoDXFIocpHFKF4vtcCJFNhE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=smoaRWX+WA+tuy1FOMpkA4tFQ/k3yn1ADSMIe/+DTk9DUzN2tPCuY/4S/LB1ll1vb 1fjJkgYQ8JkS2RmXnDDSbClhqerjSBunmK++s63sd9zpi6YtWlpdksnPOjjGaoPlE2 zQI9e7cLA1kvYo3nwAANA3IA1CmPfWUasUzwGs4gkqJfYr5fEHlIftBwL49g13HzGA 1yASSQo60IE51aU6QCmCn50a4FmK/snx9pOo7WWFXeYAJFgwAuczZVEDmJpMn2tLFS uDZiIYrcRoqWpfxiGGrGZ1rJ/NCBi3DEhjjputcygf3HVzBj5wu9Nl9ZaghkbET9Rw JDpBki4fDUAfw== Date: Wed, 30 Mar 2022 09:47:26 -0700 From: Jakub Kicinski To: Rob Herring Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Olivier Moysan , Arnaud Pouliquen , Bjorn Andersson , Georgi Djakov , Ulf Hansson , Thierry Reding , Jonathan Hunter , "David S. Miller" , Paolo Abeni , Kishon Vijay Abraham I , Vinod Koul , Mark Brown , Fabrice Gasnier , Grygorii Strashko , Dmitry Osipenko , linux-iio@vger.kernel.org, alsa-devel@alsa-project.org, linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH] dt-bindings: Fix incomplete if/then/else schemas Message-ID: <20220330094726.2132ff69@kernel.org> In-Reply-To: <20220330145741.3044896-1-robh@kernel.org> References: <20220330145741.3044896-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 30 Mar 2022 09:57:41 -0500 Rob Herring wrote: > A recent review highlighted that the json-schema meta-schema allows any > combination of if/then/else schema keywords even though if, then or else > by themselves makes little sense. With an added meta-schema to only > allow valid combinations, there's a handful of schemas found which need > fixing in a variety of ways. Incorrect indentation is the most common > issue. > > Cc: Lars-Peter Clausen > Cc: Michael Hennerich > Cc: Jonathan Cameron > Cc: Krzysztof Kozlowski > Cc: Olivier Moysan > Cc: Arnaud Pouliquen > Cc: Bjorn Andersson > Cc: Georgi Djakov > Cc: Ulf Hansson > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: "David S. Miller" > Cc: Jakub Kicinski Acked-by: Jakub Kicinski