From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C80C433F5 for ; Thu, 31 Mar 2022 08:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232540AbiCaIGL (ORCPT ); Thu, 31 Mar 2022 04:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232527AbiCaIGJ (ORCPT ); Thu, 31 Mar 2022 04:06:09 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 190D1FD1B; Thu, 31 Mar 2022 01:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648713862; x=1680249862; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bjr1qnwKFtSkCQi1HHRbtbqOK7kbxqliYYn5OAhPEe4=; b=FzkMpm29/MGbfB8RzUEBX6qV3qAolZHD1qDgoiPodZK9g8+fZP1RW4y7 +w6tDxlDQtZBur/1P3AlWAPAzsXse1kCq8MszuTPn7+EUXL0eYyatqJo8 t77x5YbLFr0KwtaEHOuuVMqs+xLjN//37V5khzg/DmxzAKhcGc3z6mYTE ryLcAOM+R6mK2SDkSTIFn0yFriZgxrf5ezG7lgpYldaXT9Tl/6i88I1WS C5819ZTzG1gx4ZGLSByshBcb9FRRfkpCA26AhVPKVU17kWhssrSy44kGn cjYIidWjnSJT+BSSNFWga++qvIlZu8h49tYjQ+lXF3UI/ZsKClM/K7xGF A==; X-IronPort-AV: E=McAfee;i="6200,9189,10302"; a="247249929" X-IronPort-AV: E=Sophos;i="5.90,224,1643702400"; d="scan'208";a="247249929" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 01:03:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,224,1643702400"; d="scan'208";a="640029355" Received: from lkp-server02.sh.intel.com (HELO 3231c491b0e2) ([10.239.97.151]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2022 01:03:50 -0700 Received: from kbuild by 3231c491b0e2 with local (Exim 4.95) (envelope-from ) id 1nZpmS-00004e-PB; Thu, 31 Mar 2022 08:03:44 +0000 Date: Thu, 31 Mar 2022 16:02:54 +0800 From: kernel test robot To: Yunfei Dong , Alexandre Courbot , Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org, Irui Wang , George Sun , Dafna Hirschfeld , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, dri-devel , Xiaoyong Lu , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Fritz Koenig , Steve Cho , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8, 16/17] media: mediatek: vcodec: support stateless VP9 decoding Message-ID: <202203311502.2PkiHB0v-lkp@intel.com> References: <20220331024801.29229-17-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331024801.29229-17-yunfei.dong@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Yunfei, Thank you for the patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on linus/master next-20220331] [cannot apply to remoteproc/rproc-next linux/master v5.17] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Yunfei-Dong/media-mediatek-vcodec-Add-vdec-enable-disable-hardware-helpers/20220331-114806 base: git://linuxtv.org/media_tree.git master config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220331/202203311502.2PkiHB0v-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7b396103061b487d6e9bc84be29de59e7eccc4c6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yunfei-Dong/media-mediatek-vcodec-Add-vdec-enable-disable-hardware-helpers/20220331-114806 git checkout 7b396103061b487d6e9bc84be29de59e7eccc4c6 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/media/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c: In function 'vdec_vp9_slice_map_counts_eob_coef': >> drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1235:69: error: assignment to 'u32 (*)[3]' {aka 'unsigned int (*)[3]'} from incompatible pointer type 'u32 (*)[4]' {aka 'unsigned int (*)[4]'} [-Werror=incompatible-pointer-types] 1235 | counts_helper->coeff[i][j][k][l][m] = | ^ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1242:69: error: assignment to 'u32 (*)[3]' {aka 'unsigned int (*)[3]'} from incompatible pointer type 'u32 (*)[4]' {aka 'unsigned int (*)[4]'} [-Werror=incompatible-pointer-types] 1242 | counts_helper->coeff[i][j][k][l][m] = | ^ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c: In function 'vdec_vp9_slice_counts_map_helper': drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1257:25: warning: unused variable 'm' [-Wunused-variable] 1257 | int i, j, k, l, m; | ^ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1257:22: warning: unused variable 'l' [-Wunused-variable] 1257 | int i, j, k, l, m; | ^ In file included from drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:12: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c: In function 'vdec_vp9_slice_lat_decode': >> drivers/media/platform/mediatek/vcodec/vdec/../mtk_vcodec_util.h:29:21: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=] 29 | #define pr_fmt(fmt) "%s(),%d: " fmt, __func__, __LINE__ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:134:29: note: in expansion of macro 'pr_fmt' 134 | func(&id, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:152:9: note: in expansion of macro '__dynamic_func_call' 152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call' 162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \ | ^~~~~~~~~~~~~~~~~~ include/linux/printk.h:570:9: note: in expansion of macro 'dynamic_pr_debug' 570 | dynamic_pr_debug(fmt, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/../mtk_vcodec_util.h:45:9: note: in expansion of macro 'pr_debug' 45 | pr_debug("[MTK_VCODEC][%d]: " fmt "\n", \ | ^~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1981:9: note: in expansion of macro 'mtk_vcodec_debug' 1981 | mtk_vcodec_debug(instance, "lat dma 1 0x%llx 0x%llx\n", | ^~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/../mtk_vcodec_util.h:29:21: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 7 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=] 29 | #define pr_fmt(fmt) "%s(),%d: " fmt, __func__, __LINE__ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:134:29: note: in expansion of macro 'pr_fmt' 134 | func(&id, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:152:9: note: in expansion of macro '__dynamic_func_call' 152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call' 162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \ | ^~~~~~~~~~~~~~~~~~ include/linux/printk.h:570:9: note: in expansion of macro 'dynamic_pr_debug' 570 | dynamic_pr_debug(fmt, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/../mtk_vcodec_util.h:45:9: note: in expansion of macro 'pr_debug' 45 | pr_debug("[MTK_VCODEC][%d]: " fmt "\n", \ | ^~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1981:9: note: in expansion of macro 'mtk_vcodec_debug' 1981 | mtk_vcodec_debug(instance, "lat dma 1 0x%llx 0x%llx\n", | ^~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c: In function 'vdec_vp9_slice_core_decode': >> drivers/media/platform/mediatek/vcodec/vdec/../mtk_vcodec_util.h:29:21: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=] 29 | #define pr_fmt(fmt) "%s(),%d: " fmt, __func__, __LINE__ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:134:29: note: in expansion of macro 'pr_fmt' 134 | func(&id, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:152:9: note: in expansion of macro '__dynamic_func_call' 152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call' 162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \ | ^~~~~~~~~~~~~~~~~~ include/linux/printk.h:570:9: note: in expansion of macro 'dynamic_pr_debug' 570 | dynamic_pr_debug(fmt, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/../mtk_vcodec_util.h:45:9: note: in expansion of macro 'pr_debug' 45 | pr_debug("[MTK_VCODEC][%d]: " fmt "\n", \ | ^~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:2050:9: note: in expansion of macro 'mtk_vcodec_debug' 2050 | mtk_vcodec_debug(instance, "core dma_addr_end 0x%llx\n", pfc->vsi.trans.dma_addr_end); | ^~~~~~~~~~~~~~~~ At top level: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:534:26: warning: 'vdec_vp9_slice_mv_fp_tree' defined but not used [-Wunused-const-variable=] 534 | static const signed char vdec_vp9_slice_mv_fp_tree[6] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:529:26: warning: 'vdec_vp9_slice_mv_class0_tree' defined but not used [-Wunused-const-variable=] 529 | static const signed char vdec_vp9_slice_mv_class0_tree[2] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:523:26: warning: 'vdec_vp9_slice_mv_class_tree' defined but not used [-Wunused-const-variable=] 523 | static const signed char vdec_vp9_slice_mv_class_tree[20] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:518:26: warning: 'vdec_vp9_slice_mv_joint_tree' defined but not used [-Wunused-const-variable=] 518 | static const signed char vdec_vp9_slice_mv_joint_tree[6] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:513:26: warning: 'vdec_vp9_slice_switchable_interp_tree' defined but not used [-Wunused-const-variable=] 513 | static const signed char vdec_vp9_slice_switchable_interp_tree[4] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:508:26: warning: 'vdec_vp9_slice_partition_tree' defined but not used [-Wunused-const-variable=] 508 | static const signed char vdec_vp9_slice_partition_tree[6] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:503:26: warning: 'vdec_vp9_slice_intra_mode_tree' defined but not used [-Wunused-const-variable=] 503 | static const signed char vdec_vp9_slice_intra_mode_tree[18] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:498:26: warning: 'vdec_vp9_slice_inter_mode_tree' defined but not used [-Wunused-const-variable=] 498 | static const signed char vdec_vp9_slice_inter_mode_tree[6] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +1235 drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c 1217 1218 static 1219 void vdec_vp9_slice_map_counts_eob_coef(unsigned int i, unsigned int j, unsigned int k, 1220 struct vdec_vp9_slice_frame_counts *counts, 1221 struct v4l2_vp9_frame_symbol_counts *counts_helper) 1222 { 1223 u32 l, m; 1224 1225 /* 1226 * helper eo -> mtk eo 1227 * helpre e1 -> mtk c3 1228 * helper c0 -> c0 1229 * helper c1 -> c1 1230 * helper c2 -> c2 1231 */ 1232 for (l = 0; l < 6; l++) { 1233 for (m = 0; m < VP9_BAND_6(l); m++) { 1234 if (l == 0) { > 1235 counts_helper->coeff[i][j][k][l][m] = 1236 &counts->coef_probs[i][j][k].band_0[m]; 1237 counts_helper->eob[i][j][k][l][m][0] = 1238 &counts->eob_branch[i][j][k].band_0[m]; 1239 counts_helper->eob[i][j][k][l][m][1] = 1240 &counts->coef_probs[i][j][k].band_0[m][3]; 1241 } else { 1242 counts_helper->coeff[i][j][k][l][m] = 1243 &counts->coef_probs[i][j][k].band_1_5[l - 1][m]; 1244 counts_helper->eob[i][j][k][l][m][0] = 1245 &counts->eob_branch[i][j][k].band_1_5[l - 1][m]; 1246 counts_helper->eob[i][j][k][l][m][1] = 1247 &counts->coef_probs[i][j][k].band_1_5[l - 1][m][3]; 1248 } 1249 } 1250 } 1251 } 1252 -- 0-DAY CI Kernel Test Service https://01.org/lkp