From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 587B4C433EF for ; Fri, 1 Apr 2022 13:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346622AbiDAOB0 (ORCPT ); Fri, 1 Apr 2022 10:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346643AbiDAOBY (ORCPT ); Fri, 1 Apr 2022 10:01:24 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B119658E4D; Fri, 1 Apr 2022 06:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1648821574; x=1680357574; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HS53eDMBd+hdkP/TyH5YuRd2CDwQeuvPwLfTlKoio/U=; b=Ja4j8SaxTHieed+YIkIudM2wslEMmwH/gb8Q5vMKyDvZ91oueSe5YAal ERdctjPdhW2GAw+ru24I2DVKUV33d7csp1p0KeT2UZpbcfw36a4XEaRWY nfqGi7AtjGHcx/E5+/3+zaMF6kby3WkovhOTOZTpqv0eJp74Lve2997N+ H6VURtew43hg/dDJfzGiiyocBrrJEeTmBjbtYE309KYIu/ZVeR8Kzjg8l floX2jIxW/N3OS3Qvv98ML1ixp7ArfIBrQwTqaP8oCDw2IsjibJhfg6vU vWERQbDUTxIlHXAThAQDU+2NZqnPNhdgY3RnM3ZkcfEqJuaLYuhZ3bEMp g==; X-IronPort-AV: E=Sophos;i="5.90,227,1643698800"; d="scan'208";a="90927628" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Apr 2022 06:59:33 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 1 Apr 2022 06:59:33 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 1 Apr 2022 06:59:32 -0700 Date: Fri, 1 Apr 2022 15:59:18 +0200 From: "Allan W. Nielsen" To: Horatiu Vultur CC: Andrew Lunn , , , , , , , , , , Subject: Re: [PATCH net 2/3] net: phy: micrel: Remove latency from driver Message-ID: <20220401135918.4tvwe6cfyku6l5wf@lx-anielsen> References: <20220401094805.3343464-1-horatiu.vultur@microchip.com> <20220401094805.3343464-3-horatiu.vultur@microchip.com> <20220401133454.ic6jxnripuxjhp5g@soft-dev3-1.localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline In-Reply-To: <20220401133454.ic6jxnripuxjhp5g@soft-dev3-1.localhost> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01.04.2022 15:34, Horatiu Vultur wrote: >The 04/01/2022 14:47, Andrew Lunn wrote: >> >> On Fri, Apr 01, 2022 at 11:48:04AM +0200, Horatiu Vultur wrote: >> > Based on the discussions here[1], the PHY driver is the wrong place >> > to set the latencies, therefore remove them. >> > >> > [1] https://lkml.org/lkml/2022/3/4/325 >> > >> > Fixes: ece19502834d84 ("net: phy: micrel: 1588 support for LAN8814 phy") >> > Signed-off-by: Horatiu Vultur >> >> Thanks for the revert. >> >> Reviewed-by: Andrew Lunn >> >> > -static struct kszphy_latencies lan8814_latencies = { >> > - .rx_10 = 0x22AA, >> > - .tx_10 = 0x2E4A, >> > - .rx_100 = 0x092A, >> > - .tx_100 = 0x02C1, >> > - .rx_1000 = 0x01AD, >> > - .tx_1000 = 0x00C9, >> > -}; >> >> What are the reset defaults of these? > >Those are actually the reset values. > >> I'm just wondering if we should >> explicitly set them to 0, so we don't get into a mess where some >> vendor bootloader sets values but mainline bootloader does not, >> breaking a configuration where the userspace daemon does the correct? > >It would be fine for me to set them to 0. But then definitely we need a >way to set these latencies from userspace. I would like to keep the default values. With default values, you can get PTP working (accuracy is not great - but it is much better than if set to zero). There is no risk of bootloaders to pre-load other values, as the kernel will reset the PHY, and after reset we will be back to these numbers. /Allan