From: Kuldeep Singh <singh.kuldeep87k@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mukesh Savaliya <msavaliy@codeaurora.org>,
Akash Asthana <akashast@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] dt-bindings: qcom: geni-se: Remove common controller properties
Date: Sun, 3 Apr 2022 01:02:20 +0530 [thread overview]
Message-ID: <20220402193220.GC35664@9a2d8922b8f1> (raw)
In-Reply-To: <5822a845-3291-70da-cbac-933983a22442@linaro.org>
On Sat, Apr 02, 2022 at 05:41:57PM +0200, Krzysztof Kozlowski wrote:
> On 02/04/2022 07:12, Kuldeep Singh wrote:
> > Now that Geni serial engine controllers(spi, i2c and uart) have their
> > own individual bindings, it's time to remove all common properties of
> > the controllers from parent schema.
> >
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> > .../bindings/soc/qcom/qcom,geni-se.yaml | 33 -------------------
> > 1 file changed, 33 deletions(-)
> >
>
> This should be squashed with your previous commit, because removal of
> last direct child schema, makes the common parts obsolete. IOW, the
> common parts are only because there is children are open-coded here.
Initially I thought the same, but then this patch will do more than what
commit description says, that's why I kept separate patch.
Nevermind, I will squash it with previous one.
-Kuldeep
prev parent reply other threads:[~2022-04-02 19:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220402051206.6115-1-singh.kuldeep87k@gmail.com>
2022-04-02 5:12 ` [PATCH 1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings Kuldeep Singh
2022-04-02 12:29 ` Krzysztof Kozlowski
2022-04-02 19:44 ` Kuldeep Singh
2022-04-02 19:57 ` Krzysztof Kozlowski
2022-04-02 18:24 ` Krzysztof Kozlowski
2022-04-02 19:34 ` Kuldeep Singh
2022-04-02 5:12 ` [PATCH 2/5] dt-bindings: qcom: geni-se: Update i2c schema reference Kuldeep Singh
2022-04-02 12:30 ` Krzysztof Kozlowski
2022-04-02 5:12 ` [PATCH 3/5] dt-bindings: serial: Update Qualcomm geni based QUP uart bindings Kuldeep Singh
2022-04-02 15:37 ` Krzysztof Kozlowski
2022-04-02 19:24 ` Kuldeep Singh
2022-04-02 5:12 ` [PATCH 4/5] dt-bindings: qcom: geni-se: Update uart schema reference Kuldeep Singh
2022-04-02 15:39 ` Krzysztof Kozlowski
2022-04-02 19:28 ` Kuldeep Singh
2022-04-02 5:12 ` [PATCH 5/5] dt-bindings: qcom: geni-se: Remove common controller properties Kuldeep Singh
2022-04-02 15:41 ` Krzysztof Kozlowski
2022-04-02 19:32 ` Kuldeep Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220402193220.GC35664@9a2d8922b8f1 \
--to=singh.kuldeep87k@gmail.com \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).