From: kernel test robot <lkp@intel.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
vigneshr@ti.com, richard@nod.at, miquel.raynal@bootlin.com,
joern@lazybastard.org
Cc: kbuild-all@lists.01.org, kernel@axis.com,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, krzk+dt@kernel.org, frowand.list@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] mtd: phram: Allow probing via reserved-memory
Date: Wed, 6 Apr 2022 13:25:34 +0800 [thread overview]
Message-ID: <202204061349.puriUTMO-lkp@intel.com> (raw)
In-Reply-To: <20220405130350.1640985-4-vincent.whitchurch@axis.com>
Hi Vincent,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mtd/mtd/next]
[also build test ERROR on mtd/mtd/fixes robh/for-next v5.18-rc1 next-20220405]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Whitchurch/mtd-phram-improvements/20220406-070357
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220406/202204061349.puriUTMO-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/5f942c36259bf6194f9cc8ed7cbacdca28200e20
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Vincent-Whitchurch/mtd-phram-improvements/20220406-070357
git checkout 5f942c36259bf6194f9cc8ed7cbacdca28200e20
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/mtd/devices/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/mtd/devices/phram.c:347:1: error: expected ',' or ';' before 'static'
347 | static int phram_probe(struct platform_device *pdev)
| ^~~~~~
>> drivers/mtd/devices/phram.c:372:27: error: 'phram_probe' undeclared here (not in a function); did you mean 'phram_write'?
372 | .probe = phram_probe,
| ^~~~~~~~~~~
| phram_write
vim +347 drivers/mtd/devices/phram.c
346
> 347 static int phram_probe(struct platform_device *pdev)
348 {
349 struct resource *res;
350
351 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
352 if (!res)
353 return -ENOMEM;
354
355 /* mtd_set_of_node() reads name from "label" */
356 return register_device(pdev, NULL, res->start, resource_size(res),
357 PAGE_SIZE);
358 }
359
360 static int phram_remove(struct platform_device *pdev)
361 {
362 struct phram_mtd_list *phram = platform_get_drvdata(pdev);
363
364 mtd_device_unregister(&phram->mtd);
365 iounmap(phram->mtd.priv);
366 kfree(phram);
367
368 return 0;
369 }
370
371 static struct platform_driver phram_driver = {
> 372 .probe = phram_probe,
373 .remove = phram_remove,
374 .driver = {
375 .name = "phram",
376 .of_match_table = of_match_ptr(phram_of_match),
377 },
378 };
379
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-06 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:03 [PATCH v2 0/4] mtd: phram improvements Vincent Whitchurch
2022-04-05 13:03 ` [PATCH v2 1/4] mtd: core: Check devicetree alias for index Vincent Whitchurch
2022-04-05 13:03 ` [PATCH v2 2/4] dt-bindings: reserved-memory: Add phram Vincent Whitchurch
2022-04-05 13:03 ` [PATCH v2 3/4] mtd: phram: Allow probing via reserved-memory Vincent Whitchurch
2022-04-06 5:25 ` kernel test robot [this message]
2022-04-05 13:03 ` [PATCH v2 4/4] mtd: phram: Allow cached mappings Vincent Whitchurch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204061349.puriUTMO-lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=joern@lazybastard.org \
--cc=kbuild-all@lists.01.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).