From: Marijn Suijten <marijn.suijten@somainline.org>
To: Joel Selvaraj <jo@jsfamily.in>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support
Date: Wed, 6 Apr 2022 18:18:39 +0200 [thread overview]
Message-ID: <20220406161839.srtt7c5eywp56i43@SoMainline.org> (raw)
In-Reply-To: <BY5PR02MB700935F5817128CB7C3991CDD9E09@BY5PR02MB7009.namprd02.prod.outlook.com>
On 2022-04-01 05:48:08, Joel Selvaraj wrote:
> Add support for backlight. This panel supports backlight control
> through the QCOM WLED driver in Xiaomi Poco F1 device.
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
> index 231f371901e8..6d6ce42787e2 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
> @@ -628,6 +628,10 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo)
>
> drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI);
>
> + ret = drm_panel_of_backlight(&pinfo->base);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to get backlight\n");
> +
> drm_panel_add(&pinfo->base);
>
> return 0;
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-04-06 17:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220401001810.81507-1-jo@jsfamily.in>
2022-04-01 0:18 ` [PATCH v2 1/3] drm/panel: nt36672a: add backlight support Joel Selvaraj
2022-04-06 16:18 ` Marijn Suijten [this message]
2022-04-21 14:26 ` (subset) " Bjorn Andersson
2022-06-07 18:31 ` Joel Selvaraj
2022-06-08 16:30 ` Sumit Semwal
2022-06-08 16:40 ` Joel Selvaraj
2022-06-08 17:52 ` Sumit Semwal
2022-06-08 17:55 ` Joel Selvaraj
2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: add backlight property Joel Selvaraj
2022-04-06 16:05 ` Rob Herring
2022-04-06 16:23 ` Marijn Suijten
2022-04-01 0:18 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel Joel Selvaraj
2022-04-06 16:21 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406161839.srtt7c5eywp56i43@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jo@jsfamily.in \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox