* [RESEND PATCH 1/2] media: dt-bindings: imx412: Add regulator descriptions
2022-04-10 16:35 [RESEND PATCH 0/2] media: i2c: imx412: Add regulator control to imx412 Bryan O'Donoghue
@ 2022-04-10 16:35 ` Bryan O'Donoghue
2022-04-10 18:43 ` Krzysztof Kozlowski
2022-04-10 16:35 ` [RESEND PATCH 2/2] media: i2c: imx412: Add bulk regulator support Bryan O'Donoghue
1 sibling, 1 reply; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-04-10 16:35 UTC (permalink / raw)
To: paul.j.murphy, daniele.alessandrelli, mchehab, linux-media,
devicetree
Cc: robert.foss, hfink, jgrahsl, dmitry.baryshkov, vladimir.zapolskiy,
bryan.odonoghue, Rob Herring, Krzysztof Kozlowski
The imx412 like many I2C camera sensors has three voltage rails which
depending on platform may be necessary to switch power onto directly.
Add in as optional rails so as not to break anything for existing users.
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/media/i2c/sony,imx412.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
index afcf70947f7e..16869a91ec9a 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
@@ -32,6 +32,18 @@ properties:
description: Clock frequency 6MHz, 12MHz, 18MHz, 24MHz or 27MHz
maxItems: 1
+ dovdd-supply:
+ description:
+ Definition of the regulator used as interface power supply.
+
+ avdd-supply:
+ description:
+ Definition of the regulator used as analog power supply.
+
+ dvdd-supply:
+ description:
+ Definition of the regulator used as digital power supply.
+
reset-gpios:
description: Reference to the GPIO connected to the XCLR pin, if any.
maxItems: 1
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [RESEND PATCH 2/2] media: i2c: imx412: Add bulk regulator support
2022-04-10 16:35 [RESEND PATCH 0/2] media: i2c: imx412: Add regulator control to imx412 Bryan O'Donoghue
2022-04-10 16:35 ` [RESEND PATCH 1/2] media: dt-bindings: imx412: Add regulator descriptions Bryan O'Donoghue
@ 2022-04-10 16:35 ` Bryan O'Donoghue
1 sibling, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-04-10 16:35 UTC (permalink / raw)
To: paul.j.murphy, daniele.alessandrelli, mchehab, linux-media,
devicetree
Cc: robert.foss, hfink, jgrahsl, dmitry.baryshkov, vladimir.zapolskiy,
bryan.odonoghue
Depending on the platform we may need to enable and disable three separate
regulators for the imx412.
- DOVDD
Digital I/O power
- AVDD
Analog power
- DVDD
Digital core power
The addition of these regulators shouldn't affect existing users using
fixed-on/firmware-controlled regulators.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/media/i2c/imx412.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
index be3f6ea55559..44b92718b6cf 100644
--- a/drivers/media/i2c/imx412.c
+++ b/drivers/media/i2c/imx412.c
@@ -11,6 +11,7 @@
#include <linux/i2c.h>
#include <linux/module.h>
#include <linux/pm_runtime.h>
+#include <linux/regulator/consumer.h>
#include <media/v4l2-ctrls.h>
#include <media/v4l2-fwnode.h>
@@ -101,6 +102,12 @@ struct imx412_mode {
struct imx412_reg_list reg_list;
};
+static const char * const imx412_supply_names[] = {
+ "dovdd", /* Digital I/O power */
+ "avdd", /* Analog power */
+ "dvdd", /* Digital core power */
+};
+
/**
* struct imx412 - imx412 sensor device structure
* @dev: Pointer to generic device
@@ -128,6 +135,8 @@ struct imx412 {
struct media_pad pad;
struct gpio_desc *reset_gpio;
struct clk *inclk;
+ struct regulator_bulk_data supplies[ARRAY_SIZE(imx412_supply_names)];
+ int num_supplies;
struct v4l2_ctrl_handler ctrl_handler;
struct v4l2_ctrl *link_freq_ctrl;
struct v4l2_ctrl *pclk_ctrl;
@@ -946,6 +955,17 @@ static int imx412_parse_hw_config(struct imx412 *imx412)
return -EINVAL;
}
+ /* Get optional DT defined regulators */
+ imx412->num_supplies = ARRAY_SIZE(imx412_supply_names);
+ for (i = 0; i < imx412->num_supplies; i++)
+ imx412->supplies[i].supply = imx412_supply_names[i];
+
+ ret = devm_regulator_bulk_get(imx412->dev,
+ imx412->num_supplies,
+ imx412->supplies);
+ if (ret)
+ return ret;
+
ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
if (!ep)
return -ENXIO;
@@ -1011,6 +1031,13 @@ static int imx412_power_on(struct device *dev)
struct imx412 *imx412 = to_imx412(sd);
int ret;
+ ret = regulator_bulk_enable(imx412->num_supplies,
+ imx412->supplies);
+ if (ret < 0) {
+ dev_err(dev, "failed to enable regulators\n");
+ goto error_reset;
+ }
+
gpiod_set_value_cansleep(imx412->reset_gpio, 1);
ret = clk_prepare_enable(imx412->inclk);
@@ -1044,6 +1071,9 @@ static int imx412_power_off(struct device *dev)
clk_disable_unprepare(imx412->inclk);
+ regulator_bulk_disable(imx412->num_supplies,
+ imx412->supplies);
+
return 0;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread