From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ls1028a: default to OTG mode for USB
Date: Mon, 11 Apr 2022 08:54:28 +0800 [thread overview]
Message-ID: <20220411005428.GV129381@dragon> (raw)
In-Reply-To: <20220330113442.3402940-1-michael@walle.cc>
On Wed, Mar 30, 2022 at 01:34:42PM +0200, Michael Walle wrote:
> At the moment, the dtsi will force the dr_mode to host. This is
> problematic because it will always turn on the Vbus voltage regardless
> if the port is host or device. This might lead to a "shortcut" between
> the two USB endpoints because both might have their Vbus supplies
> enabled. Therefore, the default should be "otg" for any ports which
> aren't host only (from a SoC point of view) and have a user of the dtsi
> file overwrite that explicitly.
>
> Move the 'dr_mode = "host";' into the board dts. Now that the dtsi
> doesn't set the dr_mode anymore, we can also drop the 'dr_mode = "otg";'
> in the board dts because that is the default value if dr_mode is not
> set.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks!
prev parent reply other threads:[~2022-04-11 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 11:34 [PATCH] arm64: dts: ls1028a: default to OTG mode for USB Michael Walle
2022-04-11 0:54 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411005428.GV129381@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox